Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(100)

Issue 1177363002: Add a new hook to WebLayerTreeView for requesting frames. (Closed)

Created:
4 years, 10 months ago by esprehn
Modified:
4 years, 10 months ago
Reviewers:
chrishtr, enne (OOO)
CC:
blink-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add a new hook to WebLayerTreeView for requesting frames. These will be implemented inside the compositor to allow Blink to signal that it wants either only BeginMainFrame to run the blink side pipeline, or that it wants the entire compositor pipeline. This will allow an early out when requestAnimationFrame (or other frame timed callbacks) are scheduled but nothing is actually dirty in compositor related state. Eventually blink will stop calling setNeedsAnimate() entirely and call one of either setNeedsBeginFrame() or setNeedsCompositorUpdate(). R=chrishtr@chromium.org BUG=490465 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197091

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M public/platform/WebLayerTreeView.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
esprehn
We can bikeshed the names if you want. :)
4 years, 10 months ago (2015-06-12 01:01:40 UTC) #2
enne (OOO)
lgtm
4 years, 10 months ago (2015-06-12 23:35:45 UTC) #3
chrishtr
lgtm
4 years, 10 months ago (2015-06-13 16:10:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177363002/1
4 years, 10 months ago (2015-06-13 20:10:32 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2015-06-13 21:28:21 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197091

Powered by Google App Engine
This is Rietveld 408576698