Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 1177353003: [turbofan] Move RawMachineAssembler to unittests. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Move RawMachineAssembler to unittests. R=mstarzinger@chromium.org Committed: https://crrev.com/b5b00cc031c15263bbc4e8e8b2bef01b6fdfd284 Cr-Commit-Position: refs/heads/master@{#28993}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -844 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D src/compiler/raw-machine-assembler.h View 1 chunk +0 lines, -523 lines 0 comments Download
D src/compiler/raw-machine-assembler.cc View 1 chunk +0 lines, -188 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/compiler/codegen-tester.h View 1 chunk +1 line, -1 line 0 comments Download
D test/cctest/compiler/instruction-selector-tester.h View 1 chunk +0 lines, -127 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.h View 1 chunk +1 line, -1 line 0 comments Download
A + test/unittests/compiler/raw-machine-assembler.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/unittests/compiler/raw-machine-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-12 09:49:55 UTC) #1
Michael Starzinger
LGTM.
5 years, 6 months ago (2015-06-12 10:30:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177353003/1
5 years, 6 months ago (2015-06-12 10:30:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-12 10:33:18 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 10:33:29 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5b00cc031c15263bbc4e8e8b2bef01b6fdfd284
Cr-Commit-Position: refs/heads/master@{#28993}

Powered by Google App Engine
This is Rietveld 408576698