Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1177343002: Update paths in sky_home.dart (Closed)

Created:
5 years, 6 months ago by eseidel
Modified:
5 years, 6 months ago
Reviewers:
Hixie
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Update paths in sky_home.dart I also removed the leading /, so it is now possible to use shelldb start sky/sky_home to test. Also fixed touch_demo.dart and sector layout to work and not crash. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/1ff9f9159d7f7b4f7404da3de85cc30c974f7734

Patch Set 1 #

Patch Set 2 : Fix touch demo and sector layout demos #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -33 lines) Patch
M sky/examples/rendering/touch_demo.dart View 1 4 chunks +24 lines, -12 lines 2 comments Download
M sky/sdk/lib/framework/rendering/box.dart View 1 2 chunks +5 lines, -12 lines 0 comments Download
M sky/sdk/lib/framework/rendering/object.dart View 1 2 chunks +8 lines, -0 lines 2 comments Download
M sky/sky_home.dart View 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
5 years, 6 months ago (2015-06-11 22:10:02 UTC) #1
Hixie
lgtm https://codereview.chromium.org/1177343002/diff/20001/sky/examples/rendering/touch_demo.dart File sky/examples/rendering/touch_demo.dart (right): https://codereview.chromium.org/1177343002/diff/20001/sky/examples/rendering/touch_demo.dart#newcode8 sky/examples/rendering/touch_demo.dart:8: import 'package:sky/framework/rendering/box.dart'; convention is now to sort this ...
5 years, 6 months ago (2015-06-11 22:14:10 UTC) #2
eseidel
5 years, 6 months ago (2015-06-11 22:17:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1ff9f9159d7f7b4f7404da3de85cc30c974f7734 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698