public/web/WebFrameClient.h - Issue 1177333002: Revert of Detach old frame on WebFrame::swap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/WebFrameClient.h

Issue 1177333002: Revert of Detach old frame on WebFrame::swap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: public/web/WebFrameClient.h

diff --git a/public/web/WebFrameClient.h b/public/web/WebFrameClient.h

index 328f5aafc22ebce7b0b6e7654a8a5d17d5be107b..83753e4d56583e146cd3948b0425642c1a3a041d 100644

--- a/public/web/WebFrameClient.h

+++ b/public/web/WebFrameClient.h

@@ -159,7 +159,7 @@

enum class DetachType { Remove, Swap };

// This frame has been detached from the view, but has not been closed yet.

- virtual void frameDetached(WebFrame*, DetachType) { }

+ virtual void frameDetached(WebFrame*) { }

// This frame has become focused..

virtual void frameFocused() { }

« no previous file with comments | « Source/web/tests/WebFrameTest.cpp ('k') | public/web/WebRemoteFrameClient.h » ('j') | no next file with comments »