Source/core/html/HTMLFrameOwnerElement.cpp - Issue 1177333002: Revert of Detach old frame on WebFrame::swap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFrameOwnerElement.cpp

Issue 1177333002: Revert of Detach old frame on WebFrame::swap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLFrameOwnerElement.cpp

diff --git a/Source/core/html/HTMLFrameOwnerElement.cpp b/Source/core/html/HTMLFrameOwnerElement.cpp

index 9da24ce2e260ce1bd67c4f76ba81e1da3940e3e0..8d6f045deb97df4eebc80e7e0c52f04d7144fa2d 100644

--- a/Source/core/html/HTMLFrameOwnerElement.cpp

+++ b/Source/core/html/HTMLFrameOwnerElement.cpp

@@ -149,7 +149,7 @@

// reach up into this document and then attempt to look back down. We should

// see if this behavior is really needed as Gecko does not allow this.

if (RefPtrWillBeRawPtr<Frame> frame = contentFrame()) {

- frame->detach(FrameDetachType::Remove);

+ frame->detach();

}

#if ENABLE(OILPAN)

// Oilpan: a plugin container must be explicitly disposed before it

« no previous file with comments | « Source/core/frame/RemoteFrame.cpp ('k') | Source/core/loader/EmptyClients.h » ('j') | no next file with comments »