Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(889)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1177333002: Revert of Detach old frame on WebFrame::swap. (Closed)

Created:
5 years, 6 months ago by dglazkov
Modified:
5 years, 6 months ago
Reviewers:
dcheng, lfg
CC:
dcheng, blink-reviews, Nate Chapin, mlamouri+watch-blink_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Detach old frame on WebFrame::swap. (patchset #15 id:270001 of https://codereview.chromium.org/1041473002/) Reason for revert: Breaks html_viewer/mandoline stuff: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/46865/steps/compile/logs/stdio Original issue's description: > Detach old frame on WebFrame::swap. > > BUG=464764 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196968 TBR=dcheng@chromium.org,lfg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=464764 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196975

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -112 lines) Patch
M Source/core/frame/Frame.h View 3 chunks +1 line, -9 lines 0 comments Download
M Source/core/frame/Frame.cpp View 3 chunks +8 lines, -9 lines 0 comments Download
M Source/core/frame/FrameClient.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/frame/LocalFrame.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
M Source/core/frame/RemoteFrame.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/frame/RemoteFrame.cpp View 2 chunks +2 lines, -8 lines 0 comments Download
M Source/core/html/HTMLFrameOwnerElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/EmptyClients.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameLoader.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 3 chunks +12 lines, -21 lines 0 comments Download
M Source/core/page/Page.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PrintContextTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 3 chunks +0 lines, -7 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/RemoteFrameClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/RemoteFrameClientImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebFrame.cpp View 4 chunks +11 lines, -19 lines 0 comments Download
M Source/web/tests/FrameTestHelpers.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/tests/FrameTestHelpers.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 2 chunks +14 lines, -0 lines 0 comments Download
M public/web/WebFrameClient.h View 1 chunk +1 line, -1 line 0 comments Download
M public/web/WebRemoteFrameClient.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
dglazkov
Created Revert of Detach old frame on WebFrame::swap.
5 years, 6 months ago (2015-06-11 21:25:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177333002/1
5 years, 6 months ago (2015-06-11 21:26:01 UTC) #2
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 21:26:41 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196975

Powered by Google App Engine
This is Rietveld 408576698