Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1177323002: Use SkPaintFilterCanvas for SampleApp paint filtering (Closed)

Created:
5 years, 6 months ago by f(malita)
Modified:
5 years, 6 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use SkPaintFilterCanvas for SampleApp paint filtering (one less SkDrawFilter user) BUG=skia:3587 R=robertphillips@google.com,reed@google.com Committed: https://skia.googlesource.com/skia/+/822ace900142aecebc5637454f8361c0d3572f3f

Patch Set 1 #

Patch Set 2 : drop SampleWindow::afterChild() #

Total comments: 4

Patch Set 3 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -23 lines) Patch
M samplecode/SampleApp.h View 1 3 chunks +1 line, -2 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 2 9 chunks +27 lines, -21 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
f(malita)
5 years, 6 months ago (2015-06-11 21:29:41 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177323002/1
5 years, 6 months ago (2015-06-11 21:43:22 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177323002/20001
5 years, 6 months ago (2015-06-12 01:37:43 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-12 11:07:59 UTC) #7
f(malita)
Bump.
5 years, 6 months ago (2015-06-15 13:06:29 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177323002/20001
5 years, 6 months ago (2015-06-15 13:06:37 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-15 13:11:38 UTC) #12
robertphillips
lgtm + nits https://codereview.chromium.org/1177323002/diff/20001/samplecode/SampleApp.cpp File samplecode/SampleApp.cpp (right): https://codereview.chromium.org/1177323002/diff/20001/samplecode/SampleApp.cpp#newcode482 samplecode/SampleApp.cpp:482: protected: '*' should go on the ...
5 years, 6 months ago (2015-06-15 13:29:31 UTC) #13
f(malita)
https://codereview.chromium.org/1177323002/diff/20001/samplecode/SampleApp.cpp File samplecode/SampleApp.cpp (right): https://codereview.chromium.org/1177323002/diff/20001/samplecode/SampleApp.cpp#newcode482 samplecode/SampleApp.cpp:482: protected: On 2015/06/15 at 13:29:30, robertphillips wrote: > '*' ...
5 years, 6 months ago (2015-06-15 13:52:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177323002/40001
5 years, 6 months ago (2015-06-15 13:53:05 UTC) #17
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 14:07:36 UTC) #18
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/822ace900142aecebc5637454f8361c0d3572f3f

Powered by Google App Engine
This is Rietveld 408576698