Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1177313006: Add markdown for GPU wrangler. (Closed)

Created:
5 years, 6 months ago by bsalomon
Modified:
5 years, 6 months ago
Reviewers:
rmistry
CC:
reviews_skia.org, skia-gpu-team_google.com
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : link #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
A site/dev/sheriffing/gpu.md View 1 2 1 chunk +59 lines, -0 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177313006/40001
5 years, 6 months ago (2015-06-15 14:16:22 UTC) #3
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/1692bd12b529b573873dd96becce5b0aabf18bbd
5 years, 6 months ago (2015-06-15 14:17:02 UTC) #4
rmistry
lgtm https://codereview.chromium.org/1177313006/diff/40001/site/dev/sheriffing/gpu.md File site/dev/sheriffing/gpu.md (right): https://codereview.chromium.org/1177313006/diff/40001/site/dev/sheriffing/gpu.md#newcode30 site/dev/sheriffing/gpu.md:30: Note that the wrangler's job is NOT to ...
5 years, 6 months ago (2015-06-15 14:19:01 UTC) #5
bsalomon
GPU team, please check out the docs and update accordingly. I landed it because having ...
5 years, 6 months ago (2015-06-15 14:19:17 UTC) #6
bsalomon
5 years, 6 months ago (2015-06-15 14:25:30 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/1177313006/diff/40001/site/dev/sheriffing/gpu.md
File site/dev/sheriffing/gpu.md (right):

https://codereview.chromium.org/1177313006/diff/40001/site/dev/sheriffing/gpu...
site/dev/sheriffing/gpu.md:30: Note that the wrangler's job is NOT to spend an
abnormal amount of time triaging images, filing bugs for failing bots, or
shepherding DEPS rolls. You'll get your chance when you are the general Skia
sheriff.
On 2015/06/15 14:19:01, rmistry wrote:
> The members of the GPU wrangler should not be removed from the general Skia
> sheriff rotation?

Let's start off not removed and see how it goes.

Powered by Google App Engine
This is Rietveld 408576698