Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 11773047: [Android] Fix for apk_info.py dependency error. (Closed)

Created:
7 years, 11 months ago by craigdh
Modified:
7 years, 11 months ago
Reviewers:
Isaac (away), frankf
CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

[Android] Fix for apk_info.py dependency error. BUG=168813 TEST=adb_install_apk.py --apk=$PATH_TO_APK Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175563

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/adb_install_apk.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
craigdh
adb_install_apk.py needs to be updated now that apk_info.py has been moved to pylib/instrumentation. Causing android_fyi_dbg_triggered_tests ...
7 years, 11 months ago (2013-01-08 18:12:55 UTC) #1
frankf
lgtm
7 years, 11 months ago (2013-01-08 18:21:58 UTC) #2
Isaac (away)
Thanks for the fix. In the future please send python refactoring patches through the android_fyi_dbg ...
7 years, 11 months ago (2013-01-08 19:03:02 UTC) #3
frankf
The issue is stale *.pyc files. See the other CL. On 2013/01/08 19:03:02, Isaac wrote: ...
7 years, 11 months ago (2013-01-08 19:05:53 UTC) #4
craigdh
On 2013/01/08 19:03:02, Isaac wrote: > Thanks for the fix. In the future please send ...
7 years, 11 months ago (2013-01-08 19:08:45 UTC) #5
Isaac (away)
Yep, sorry. Foot in mouth. Could one of you file a bug to track this? ...
7 years, 11 months ago (2013-01-08 19:13:34 UTC) #6
frankf
7 years, 11 months ago (2013-01-08 19:21:04 UTC) #7
Message was sent while issue was closed.
Filed: crbug.com/168835

On 2013/01/08 19:13:34, Isaac wrote:
> Yep, sorry. Foot in mouth. 
> 
> Could one of you file a bug to track this?  I think it's a general chromium
> issue.

Powered by Google App Engine
This is Rietveld 408576698