Implementation of sensitive card information escrowing

chrome/browser/autofill/wallet/wallet_client.h

Index: chrome/browser/autofill/wallet/wallet_client.h
diff --git a/chrome/browser/autofill/wallet/wallet_client.h b/chrome/browser/autofill/wallet/wallet_client.h
index 130499c2870365ac6b195d1e841ba3df45c16b51..7322feb9734afbeae5d7d0113400182fa77c811e 100644
--- a/chrome/browser/autofill/wallet/wallet_client.h
+++ b/chrome/browser/autofill/wallet/wallet_client.h
@@ -41,6 +41,10 @@ class WalletClient : public net::URLFetcherDelegate {
     virtual void OnEncryptOtp(const std::string& encrypted_otp,
                               const std::string& session_material) = 0;
 
+    // Called when an EscrowSensitiveInformation request finishes successfully.
+    virtual void OnEscrowSensitiveInformation(

[Ilya Sherman, 2013/01/09 23:30:48]

nit: Perhaps OnDidEscrowSensitiveInformation or
OnReceivedEscrowSensitiveInformation?

[Albert Bodenhamer, 2013/01/09 23:58:43]

There needs to be a bit of info here or elsewhere (maybe I'm missing it) about
what it means to "Escrow Sensitive Information"

[ahutter, 2013/01/10 00:24:46]

Changed to OnDidEscrowSensitiveInformation. Should the rest of the callback
methods be named like that? If so, I will do it in a separate CL.

[ahutter, 2013/01/10 00:24:46]

Added a comment.

[Ilya Sherman, 2013/01/10 00:35:40]

Yes, that would be helpful.  Thanks.

+        const std::string& escrow_handle) = 0;
+
     // Called when a GetFullWallet request finishes successfully. Caller owns
     // the input pointer.
     virtual void OnGetFullWallet(FullWallet* full_wallet) = 0;
@@ -87,6 +91,14 @@ class WalletClient : public net::URLFetcherDelegate {
                   size_t length,
                   WalletClientObserver* observer);
 
+  // Before calling SaveToWallet with a new instrument, the client must escrow
+  // the primary account number, |pan|, and card verfication number, |cvn|, with
+  // Google Wallet.

[Ilya Sherman, 2013/01/09 23:30:48]

Why not just spell out primary_account_number and card_verification_number for
the variable names?  The fact that you're having to expand the acronyms in the
comment suggests that they are not clear enough to stand on their own.

[ahutter, 2013/01/10 00:24:46]

Done.

+  void EscrowSensitiveInformation(const std::string& pan,
+                                  const std::string& cvn,
+                                  const std::string& obfuscated_gaia_id,
+                                  WalletClientObserver* observer);
+
   // GetFullWallet retrieves the a FullWallet for the user. |instrument_id| and
   // |adddress_id| should have been selected by the user in some UI,
   // |merchant_domain| should come from the BrowserContext, the |cart|
@@ -121,6 +133,7 @@ class WalletClient : public net::URLFetcherDelegate {
     NO_PENDING_REQUEST,
     ACCEPT_LEGAL_DOCUMENTS,
     ENCRYPT_OTP,
+    ESCROW_SENSITIVE_INFORMATION,
     GET_FULL_WALLET,
     GET_WALLET_ITEMS,
     SEND_STATUS,