Implementation of sensitive card information escrowing

chrome/browser/autofill/wallet/wallet_client_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/logging.h"
 #include "base/string_number_conversions.h"
 #include "base/string_util.h"
 #include "chrome/browser/autofill/wallet/cart.h"
 #include "chrome/browser/autofill/wallet/full_wallet.h"
 #include "chrome/browser/autofill/wallet/wallet_client.h"
@@ skipping 149 matching lines @@
 
 const char kSendExtendedAutofillStatusOfFailureValidRequest[] =
     "{"
         "\"api_key\":\"abcdefg\","
         "\"google_transaction_id\":\"google_transaction_id\","
         "\"hostname\":\"hostname\","
         "\"reason\":\"CANNOT_PROCEED\","
         "\"success\":false"
     "}";
 
+const char kEscrowSensitiveInformationRequest[] =
+    "gid=obfuscated_gaia_id&cardNumber=pan&cvv=cvn";
+
 }  // anonymous namespace
 
 namespace wallet {
 
 class WalletClientTest : public testing::Test {
  public:
   WalletClientTest() : io_thread_(content::BrowserThread::IO) {}
 
   virtual void SetUp() {
     io_thread_.StartIOThread();
@@ skipping 15 matching lines @@
 
 class MockWalletClientObserver
     : public wallet::WalletClient::WalletClientObserver {
  public:
   MockWalletClientObserver() {}
   ~MockWalletClientObserver() {}
 
   MOCK_METHOD0(OnAcceptLegalDocuments, void());
   MOCK_METHOD2(OnEncryptOtp, void(const std::string& encrypted_otp,
                                   const std::string& session_material));
+  MOCK_METHOD1(OnEscrowSensitiveInformation,
+               void(const std::string& escrow_handle));
   MOCK_METHOD1(OnGetFullWallet, void(FullWallet* full_wallet));
   MOCK_METHOD1(OnGetWalletItems, void(WalletItems* wallet_items));
   MOCK_METHOD0(OnSendExtendedAutofillStatus, void());
   MOCK_METHOD0(OnWalletError, void());
   MOCK_METHOD1(OnNetworkError, void(int response_code));
 };
 
 // TODO(ahutter): Implement API compatibility tests. See
 // http://crbug.com/164465.
 
@@ skipping 67 matching lines @@
 
   WalletClient wallet_client(profile_.GetRequestContext());
   wallet_client.SendExtendedAutofillStatus(true, "", "", "", &observer);
   net::TestURLFetcher* fetcher = factory.GetFetcherByID(0);
   DCHECK(fetcher);
   fetcher->set_response_code(net::HTTP_BAD_REQUEST);
   fetcher->delegate()->OnURLFetchComplete(fetcher);
 }
 
 // TODO(ahutter): Add test for EncryptOtp.
-// TODO(ahutter): Add retry and failure tests for EncryptOtp, GetWalletItems,
+// TODO(ahutter): Add failure tests for EncryptOtp, GetWalletItems,
 // GetFullWallet for when data is missing or invalid.
 
+TEST_F(WalletClientTest, EscrowSensitiveInformationSuccess) {
+  MockWalletClientObserver observer;
+  EXPECT_CALL(observer, OnEscrowSensitiveInformation("abc")).Times(1);
+
+  net::TestURLFetcherFactory factory;
+
+  WalletClient wallet_client(profile_.GetRequestContext());
+  wallet_client.EscrowSensitiveInformation("pan",
+                                           "cvn",
+                                           "obfuscated_gaia_id",
+                                           &observer);
+  net::TestURLFetcher* fetcher = factory.GetFetcherByID(0);
+  DCHECK(fetcher);

[Ilya Sherman, 2013/01/09 23:30:48]

Unit tests should not use DCHECKs, as they can crash the test binary.  Use an
ASSERT_ instead.

[ahutter, 2013/01/10 00:24:46]

Done.

+  ASSERT_EQ(kEscrowSensitiveInformationRequest, fetcher->upload_data());

[Ilya Sherman, 2013/01/09 23:30:48]

nit: I think Chrome code prefers EXPECT_EQ for this sort of check.

[ahutter, 2013/01/10 00:24:46]

Done.

+  fetcher->set_response_code(net::HTTP_OK);
+  fetcher->SetResponseString("abc");
+  fetcher->delegate()->OnURLFetchComplete(fetcher);
+}
+
+TEST_F(WalletClientTest, EscrowSensitiveInformationFailure) {
+  MockWalletClientObserver observer;
+  EXPECT_CALL(observer, OnWalletError()).Times(1);
+
+  net::TestURLFetcherFactory factory;
+
+  WalletClient wallet_client(profile_.GetRequestContext());
+  wallet_client.EscrowSensitiveInformation("pan",
+                                           "cvn",
+                                           "obfuscated_gaia_id",
+                                           &observer);
+  net::TestURLFetcher* fetcher = factory.GetFetcherByID(0);
+  DCHECK(fetcher);
+  ASSERT_EQ(kEscrowSensitiveInformationRequest, fetcher->upload_data());
+  fetcher->set_response_code(net::HTTP_OK);
+  fetcher->SetResponseString("");
+  fetcher->delegate()->OnURLFetchComplete(fetcher);
+}
+
 TEST_F(WalletClientTest, GetFullWallet) {
   MockWalletClientObserver observer;
   EXPECT_CALL(observer, OnGetFullWallet(testing::NotNull())).Times(1);
 
   net::TestURLFetcherFactory factory;
 
   WalletClient wallet_client(profile_.GetRequestContext());
   Cart cart("currency_code", "currency_code");
   wallet_client.GetFullWallet("instrument_id",
                               "shipping_address_id",
@@ skipping 82 matching lines @@
   net::TestURLFetcher* fetcher = factory.GetFetcherByID(0);
   DCHECK(fetcher);
   ASSERT_EQ(kSendExtendedAutofillStatusOfFailureValidRequest,
             fetcher->upload_data());
   fetcher->set_response_code(net::HTTP_OK);
   fetcher->delegate()->OnURLFetchComplete(fetcher);
 }
 
 }  // namespace wallet