Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 11773036: ObsoleteOSInfoBar -> ObsoleteOSInfoBarDelegate, for consistency with other infobar delegates. (Closed)

Created:
7 years, 11 months ago by Peter Kasting
Modified:
7 years, 8 months ago
Reviewers:
Robert Sesek, sky
CC:
chromium-reviews
Visibility:
Public.

Description

ObsoleteOSInfoBar -> ObsoleteOSInfoBarDelegate, for consistency with other infobar delegates. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194479

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -147 lines) Patch
D chrome/browser/ui/startup/obsolete_os_info_bar.h View 1 2 3 4 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/ui/startup/obsolete_os_info_bar.cc View 1 2 3 4 1 chunk +0 lines, -81 lines 0 comments Download
A + chrome/browser/ui/startup/obsolete_os_infobar_delegate.h View 1 2 3 3 chunks +9 lines, -9 lines 0 comments Download
A + chrome/browser/ui/startup/obsolete_os_infobar_delegate.cc View 1 2 3 4 4 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Peter Kasting
7 years, 11 months ago (2013-01-07 23:44:27 UTC) #1
Robert Sesek
LGTM
7 years, 11 months ago (2013-01-08 00:31:08 UTC) #2
Peter Kasting
sky: chrome/ OWNERS
7 years, 11 months ago (2013-01-08 01:25:16 UTC) #3
sky
7 years, 11 months ago (2013-01-08 04:48:52 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698