Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 11773033: Revert 175356 (Closed)

Created:
7 years, 11 months ago by bbudge
Modified:
7 years, 11 months ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 175356 NaCl revision r10541 caused syzygy to blow up because it wasn't able to understand a hard coded jmp instruction. syzygy failed with the error: 657>[0107/120807 : error : decomposer.cc(2354)] Unable to translate absolute to relative addresses. 657>[0107/120807 : error : pe_relinker.cc(218)] Unable to decompose module: C:\b\build\slave\Win\build\src\build\Release\chrome.dll 657>[0107/120808 : error : relink_app.cc(199)] Failed to initialize relinker. (from http://build.chromium.org/p/chromium/builders/Win/builds/14491/) > NaCl: Update revision in DEPS, r10533 -> r10542 > > This pulls in the following Native Client changes: > > r10534: (mseaborn) Mac: Fix an off-by-one corner case in handling single-stepping on x86-32 > r10535: (mseaborn) Thread suspension: Fix querying registers for another Mac OS X corner case > r10536: (mcgrathr) toolchain_build: Update binutils and gcc revisions > r10537: (mseaborn) GDB tests: Improve error reporting when GDB's "reason" field is missing > r10538: (eliben) Fix pnacl driver tests to look for x64 host dir when x86-32 isn't built > r10539: (jfb) ARM: delete stale files and code. > r10540: (mcgrathr) Disable performance tests under qemu > r10541: (mcgrathr) Segregate trusted/untrusted values of MXCSR > r10542: (mcgrathr) Disable run_performance_test via tests_to_disable_qemu not is_broken > > BUG=none > TEST=nacl_integration > > Review URL: https://codereview.chromium.org/11792004 TBR=mseaborn@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175406

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
bbudge
7 years, 11 months ago (2013-01-07 22:41:16 UTC) #1
Mark Seaborn
7 years, 11 months ago (2013-01-07 23:16:58 UTC) #2
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698