Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: LayoutTests/svg/dom/SVGPathSegList-appendItem.xhtml

Issue 1177303004: Updated SVGListPropertyHelper as per SVG2 Spec (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fixed presubmit error Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/svg/dom/SVGPathSegList-appendItem.xhtml
diff --git a/LayoutTests/svg/dom/SVGPathSegList-appendItem.xhtml b/LayoutTests/svg/dom/SVGPathSegList-appendItem.xhtml
index ff6d4ffbae6db13c29fafff6c6b5a41e5dc8e863..eefb80cf7d4cf8c99a4c3fa86a33f41783673b82 100644
--- a/LayoutTests/svg/dom/SVGPathSegList-appendItem.xhtml
+++ b/LayoutTests/svg/dom/SVGPathSegList-appendItem.xhtml
@@ -55,9 +55,24 @@
shouldBe("path2.pathSegList.getItem(3).x = -path2.pathSegList.getItem(3).x", "-100");
debug("")
- debug("Swap segment four and five of path2 - now should look like a rectangle");
+ debug("Append second item from path1 to path2 list");
shouldBeEqualToString("path2.pathSegList.appendItem(path2.pathSegList.getItem(3)).toString()", "[object SVGPathSegLinetoHorizontalRel]");
-
+ shouldBe("path2.pathSegList.numberOfItems", "6");
+ shouldBeEqualToString("path2.pathSegList.getItem(0).toString()", "[object SVGPathSegMovetoAbs]");
+ shouldBe("path2.pathSegList.getItem(0).x", "0");
+ shouldBe("path2.pathSegList.getItem(0).y", "0");
+ shouldBeEqualToString("path2.pathSegList.getItem(1).toString()", "[object SVGPathSegLinetoAbs]");
+ shouldBe("path2.pathSegList.getItem(1).x", "50");
+ shouldBe("path2.pathSegList.getItem(1).y", "100");
+ shouldBeEqualToString("path2.pathSegList.getItem(2).toString()", "[object SVGPathSegLinetoHorizontalRel]");
+ shouldBe("path2.pathSegList.getItem(2).x", "100");
+ shouldBeEqualToString("path2.pathSegList.getItem(3).toString()", "[object SVGPathSegLinetoHorizontalRel]");
+ shouldBe("path2.pathSegList.getItem(3).x", "-100");
+ shouldBeEqualToString("path2.pathSegList.getItem(4).toString()", "[object SVGPathSegLinetoVerticalRel]");
+ shouldBe("path2.pathSegList.getItem(4).y", "100");
+ shouldBeEqualToString("path2.pathSegList.getItem(5).toString()", "[object SVGPathSegLinetoHorizontalRel]");
+ shouldBe("path2.pathSegList.getItem(5).x", "-100");
+
debug("");
debug("Append second item from path2 to path1 list");
shouldBeEqualToString("path1.pathSegList.appendItem(path2.pathSegList.getItem(1)).toString()", "[object SVGPathSegLinetoAbs]");
@@ -67,6 +82,14 @@
shouldBe("path1.pathSegList.getItem(3).x -= 50", "0");
debug("");
+ debug("Reset points attribute to M 0 0 L 100 0 v 100");
+ shouldBeUndefined("path2.setAttribute('d', 'M 0 0 L 100 0 v 100')");
+
+ debug("")
+ debug("Append fourth item from path1 to path2 list - now should look like a rectangle");
+ shouldBeEqualToString("path2.pathSegList.appendItem(path1.pathSegList.getItem(3)).toString()", "[object SVGPathSegLinetoAbs]");
+
+ debug("");
debug("Check final 'pathSegList' value of path1");
shouldBe("path1.pathSegList.numberOfItems", "4");
shouldBeEqualToString("path1.pathSegList.getItem(0).toString()", "[object SVGPathSegMovetoAbs]");
@@ -88,12 +111,14 @@
shouldBeEqualToString("path2.pathSegList.getItem(0).toString()", "[object SVGPathSegMovetoAbs]");
shouldBe("path2.pathSegList.getItem(0).x", "0");
shouldBe("path2.pathSegList.getItem(0).y", "0");
- shouldBeEqualToString("path2.pathSegList.getItem(1).toString()", "[object SVGPathSegLinetoHorizontalRel]");
+ shouldBeEqualToString("path2.pathSegList.getItem(1).toString()", "[object SVGPathSegLinetoAbs]");
shouldBe("path2.pathSegList.getItem(1).x", "100");
+ shouldBe("path1.pathSegList.getItem(1).y", "0");
shouldBeEqualToString("path2.pathSegList.getItem(2).toString()", "[object SVGPathSegLinetoVerticalRel]");
shouldBe("path2.pathSegList.getItem(2).y", "100");
- shouldBeEqualToString("path2.pathSegList.getItem(3).toString()", "[object SVGPathSegLinetoHorizontalRel]");
- shouldBe("path2.pathSegList.getItem(3).x", "-100");
+ shouldBeEqualToString("path2.pathSegList.getItem(3).toString()", "[object SVGPathSegLinetoAbs]");
+ shouldBe("path2.pathSegList.getItem(3).x", "0");
+ shouldBe("path1.pathSegList.getItem(3).y", "100");
]]>
</script>
« no previous file with comments | « LayoutTests/svg/dom/SVGNumberList-basics-expected.txt ('k') | LayoutTests/svg/dom/SVGPathSegList-appendItem-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698