Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Side by Side Diff: Source/core/svg/SVGPathSegListTearOff.h

Issue 1177303004: Updated SVGListPropertyHelper as per SVG2 Spec (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: small nits Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 30 matching lines...) Expand all
41 class ListItemPropertyTraits<SVGPathSeg> { 41 class ListItemPropertyTraits<SVGPathSeg> {
42 public: 42 public:
43 typedef SVGPathSeg ItemPropertyType; 43 typedef SVGPathSeg ItemPropertyType;
44 // FIXME: Currently SVGPathSegitself is a tear-off. 44 // FIXME: Currently SVGPathSegitself is a tear-off.
45 typedef SVGPathSeg ItemTearOffType; 45 typedef SVGPathSeg ItemTearOffType;
46 46
47 static PassRefPtrWillBeRawPtr<ItemPropertyType> getValueForInsertionFromTear Off(PassRefPtrWillBeRawPtr<ItemTearOffType> passNewItem, SVGElement* contextElem ent, const QualifiedName& attributeName) 47 static PassRefPtrWillBeRawPtr<ItemPropertyType> getValueForInsertionFromTear Off(PassRefPtrWillBeRawPtr<ItemTearOffType> passNewItem, SVGElement* contextElem ent, const QualifiedName& attributeName)
48 { 48 {
49 ASSERT(attributeName == SVGNames::dAttr); 49 ASSERT(attributeName == SVGNames::dAttr);
50 RefPtrWillBeRawPtr<ItemTearOffType> newItem = passNewItem; 50 RefPtrWillBeRawPtr<ItemTearOffType> newItem = passNewItem;
51
52 // SVG2-Draft Spec: If newItem is already in a list, then a new object i s created with the same values as newItem and this item is inserted into the lis t.
fs 2015/06/17 16:02:05 I think I would prefer just "Spec" here, you can d
Shanmuga Pandi 2015/06/18 11:30:45 Done.
53 // Otherwise, newItem itself is inserted into the list.
54 if (newItem->ownerList())
55 newItem = newItem->clone();
56
51 newItem->setContextElement(contextElement); 57 newItem->setContextElement(contextElement);
52 return newItem.release(); 58 return newItem.release();
53 } 59 }
54 60
55 static PassRefPtrWillBeRawPtr<ItemTearOffType> createTearOff(PassRefPtrWillB eRawPtr<ItemPropertyType> passValue, SVGElement* contextElement, PropertyIsAnimV alType, const QualifiedName&) 61 static PassRefPtrWillBeRawPtr<ItemTearOffType> createTearOff(PassRefPtrWillB eRawPtr<ItemPropertyType> passValue, SVGElement* contextElement, PropertyIsAnimV alType, const QualifiedName&)
56 { 62 {
57 RefPtrWillBeRawPtr<SVGPathSeg> value = passValue; 63 RefPtrWillBeRawPtr<SVGPathSeg> value = passValue;
58 value->setContextElement(contextElement); 64 value->setContextElement(contextElement);
59 return value.release(); 65 return value.release();
60 } 66 }
(...skipping 10 matching lines...) Expand all
71 } 77 }
72 78
73 private: 79 private:
74 SVGPathSegListTearOff(PassRefPtrWillBeRawPtr<SVGPathSegList> target, SVGElem ent* contextElement, PropertyIsAnimValType propertyIsAnimVal, const QualifiedNam e& attributeName = QualifiedName::null()) 80 SVGPathSegListTearOff(PassRefPtrWillBeRawPtr<SVGPathSegList> target, SVGElem ent* contextElement, PropertyIsAnimValType propertyIsAnimVal, const QualifiedNam e& attributeName = QualifiedName::null())
75 : SVGListPropertyTearOffHelper<SVGPathSegListTearOff, SVGPathSegList>(ta rget, contextElement, propertyIsAnimVal, attributeName) { } 81 : SVGListPropertyTearOffHelper<SVGPathSegListTearOff, SVGPathSegList>(ta rget, contextElement, propertyIsAnimVal, attributeName) { }
76 }; 82 };
77 83
78 } // namespace blink 84 } // namespace blink
79 85
80 #endif // SVGPathSegListTearOff_h 86 #endif // SVGPathSegListTearOff_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698