LayoutTests/svg/dom/SVGTransformList-more.html - Issue 1177303004: Updated SVGListPropertyHelper as per SVG2 Spec

Side by Side Diff: LayoutTests/svg/dom/SVGTransformList-more.html

Issue 1177303004: Updated SVGListPropertyHelper as per SVG2 Spec (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: small nits Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/TestExpectations ('K') | « LayoutTests/svg/dom/SVGTransformList-basics-expected.txt ('k') | LayoutTests/svg/dom/SVGTransformList-more-expected.txt » ('j') | LayoutTests/svg/dom/resources/SVGTransformList-helper.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>
	fs 2015/06/17 16:02:04 Could we get a better name than -more? Could we get a better name than -more? Shanmuga Pandi 2015/06/18 11:30:45 Done. Show quoted text On 2015/06/17 16:02:04, fs wrote: > Could we get a better name than *-more? Done.
	2 <head>
	fs 2015/06/17 16:02:04 Don't need <head> or <body>. Don't need <head> or <body>. Shanmuga Pandi 2015/06/18 11:30:45 Done. Show quoted text On 2015/06/17 16:02:04, fs wrote: > Don't need <head> or <body>. Done.
	3 <script src="../../resources/js-test.js"></script>

	4 <script src="resources/SVGTransformList-helper.js"></script>

	5 </head>

	6 <body>

	7 <svg id="svg" xmlns="http://www.w3.org/2000/svg" width="200" height="200">

	8 <circle id="circle1" cx="40" cy="40" r="40" fill="green" transform="scale(2, 2)"/>

	9 <circle id="circle2" cx="40" cy="40" r="40" fill="green" transform="scale(2, 2)"/>

	10 </svg>

	11

	12 <p id="description"></p>

	13 <div id="console"></div>
	fs 2015/06/17 16:02:04 Shouldn't need these two. Shouldn't need these two. Shanmuga Pandi 2015/06/18 11:30:45 Done. Show quoted text On 2015/06/17 16:02:04, fs wrote: > Shouldn't need these two. Done.
	14 <script type="text/javascript">

	15 description("This is a test of more SVGTransformList API parts.");

	16

	17 if (window.testRunner)

	18 testRunner.dumpAsText();

	19

	20 var svg = document.getElementById("svg");

	21 var circle1 = document.getElementById("circle1");

	22 var circle2 = document.getElementById("circle2");

	23

	24 var translate = svg.createSVGTransform();

	25 translate.setTranslate(100, 100);

	26

	27 var scale = svg.createSVGTransform();

	28 scale.setScale(3, 3);

	29

	30 debug("Test applying same transform to many SVGTransformList by appendItem() ");
	fs 2015/06/17 16:02:05 Maybe: "Test appendItem with SVGTransform that al Maybe: "Test appendItem with SVGTransform that already exist in a list." or some variant thereof. Same for all the other ones (but appendItem replaced of course...) Shanmuga Pandi 2015/06/18 11:30:45 Done. Show quoted text On 2015/06/17 16:02:05, fs wrote: > Maybe: > > "Test appendItem with SVGTransform that already exist in a list." > > or some variant thereof. Same for all the other ones (but appendItem replaced of > course...) Done.
	31 circle1.transform.baseVal.appendItem(translate);
	fs 2015/06/17 16:02:04 Maybe do: var transformList1 = circle1.transform. Maybe do: var transformList1 = circle1.transform.baseVal; to reduce the level of verboseness a bit. Shanmuga Pandi 2015/06/18 11:30:45 Done. Show quoted text On 2015/06/17 16:02:04, fs wrote: > Maybe do: > > var transformList1 = circle1.transform.baseVal; > > to reduce the level of verboseness a bit. Done.
	32 circle2.transform.baseVal.appendItem(translate);

	33 shouldBe("circle1.transform.baseVal.numberOfItems", "2");

	34 shouldBe("circle2.transform.baseVal.numberOfItems", "2");

	35 shouldBeEqualToString("dumpTransform(circle1.transform.baseVal.getItem(1))", "type=SVG_TRANSFORM_TRANSLATE matrix=[1.0 0.0 0.0 1.0 100.0 100.0]");

	36 shouldBeEqualToString("dumpTransform(circle2.transform.baseVal.getItem(1))", "type=SVG_TRANSFORM_TRANSLATE matrix=[1.0 0.0 0.0 1.0 100.0 100.0]");

	37

	38 debug("Test changing SVGTransform value");

	39 translate.setTranslate(200, 200);

	40 shouldBeEqualToString("dumpTransform(circle1.transform.baseVal.getItem(1))", "type=SVG_TRANSFORM_TRANSLATE matrix=[1.0 0.0 0.0 1.0 200.0 200.0]");

	41 shouldBeEqualToString("dumpTransform(circle2.transform.baseVal.getItem(1))", "type=SVG_TRANSFORM_TRANSLATE matrix=[1.0 0.0 0.0 1.0 100.0 100.0]");

	42

	43

	44 debug("Test applying same transform to many SVGTransformList by insertItemBe fore()");

	45 circle1.transform.baseVal.insertItemBefore(translate,0);

	46 circle2.transform.baseVal.insertItemBefore(translate,0);

	47 shouldBeEqualToString("dumpTransform(circle1.transform.baseVal.getItem(0))", "type=SVG_TRANSFORM_TRANSLATE matrix=[1.0 0.0 0.0 1.0 200.0 200.0]");

	48 shouldBeEqualToString("dumpTransform(circle2.transform.baseVal.getItem(0))", "type=SVG_TRANSFORM_TRANSLATE matrix=[1.0 0.0 0.0 1.0 200.0 200.0]");

	49 shouldBe("circle1.transform.baseVal.numberOfItems", "3");

	50 shouldBe("circle2.transform.baseVal.numberOfItems", "3");

	51

	52 debug("Test applying same transform to many SVGTransformList by replaceItem( )");

	53 circle1.transform.baseVal.replaceItem(scale,2);

	54 circle2.transform.baseVal.replaceItem(scale,2);

	55 shouldBeEqualToString("dumpTransform(circle1.transform.baseVal.getItem(2))", "type=SVG_TRANSFORM_SCALE matrix=[3.0 0.0 0.0 3.0 0.0 0.0]");

	56 shouldBeEqualToString("dumpTransform(circle2.transform.baseVal.getItem(2))", "type=SVG_TRANSFORM_SCALE matrix=[3.0 0.0 0.0 3.0 0.0 0.0]");

	57 shouldBe("circle1.transform.baseVal.numberOfItems", "3");

	58 shouldBe("circle2.transform.baseVal.numberOfItems", "3");

	59

	60

	61 debug("Test applying same transform to many SVGTransformList by initialize() ");

	62 circle1.transform.baseVal.initialize(scale);

	63 circle2.transform.baseVal.initialize(scale);

	64 shouldBeEqualToString("dumpTransform(circle1.transform.baseVal.getItem(0))", "type=SVG_TRANSFORM_SCALE matrix=[3.0 0.0 0.0 3.0 0.0 0.0]");

	65 shouldBeEqualToString("dumpTransform(circle2.transform.baseVal.getItem(0))", "type=SVG_TRANSFORM_SCALE matrix=[3.0 0.0 0.0 3.0 0.0 0.0]");

	66 shouldBe("circle1.transform.baseVal.numberOfItems", "1");

	67 shouldBe("circle2.transform.baseVal.numberOfItems", "1");

	68

	69 </script>

	70 </body>

OLD	NEW