Chromium Code Reviews Chromium Code Reviews
Issue 1177303004:
Updated SVGListPropertyHelper as per SVG2 Spec (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| OLD | NEW |
|---|---|
| (Empty) | |
| 1 <html xmlns="http://www.w3.org/1999/xhtml"> | |
|
pdr.
2015/06/12 20:23:24
Nit: Please use <!DOCTYPE HTML> as the first line.
Shanmuga Pandi
2015/06/13 07:01:32
Done.
| |
| 2 <head> | |
| 3 <script>window.enablePixelTesting = true;</script> | |
| 4 <script src="../../resources/js-test.js"></script> | |
| 5 </head> | |
| 6 <body> | |
| 7 <svg id="svg" xmlns="http://www.w3.org/2000/svg" width="200" height="200"> | |
| 8 <circle id="circle1" cx="40" cy="40" r="40" fill="green" transform="scale(2, 2)"/> | |
| 9 <circle id="circle2" cx="40" cy="40" r="40" fill="green" transform="scale(2, 2)"/> | |
| 10 </svg> | |
| 11 | |
| 12 <p id="description"></p> | |
| 13 <div id="console"></div> | |
| 14 <script type="text/javascript"> | |
| 15 <![CDATA[ | |
| 16 description("This is a test of more SVGTransformList API parts."); | |
| 17 | |
| 18 if (window.testRunner) | |
| 19 testRunner.dumpAsText(); | |
| 20 | |
| 21 function dumpMatrix(matrix) { | |
| 22 return "[" + matrix.a.toFixed(1) | |
| 23 + " " + matrix.b.toFixed(1) | |
| 24 + " " + matrix.c.toFixed(1) | |
| 25 + " " + matrix.d.toFixed(1) | |
| 26 + " " + matrix.e.toFixed(1) | |
| 27 + " " + matrix.f.toFixed(1) | |
| 28 + "]"; | |
| 29 } | |
| 30 | |
| 31 function dumpTransform(transform) { | |
|
pdr.
2015/06/12 20:23:24
Instead of copying these, lets move them to a comm
Shanmuga Pandi
2015/06/13 07:01:31
Done.
| |
| 32 var transformTypes = { | |
| 33 "0": "SVG_TRANSFORM_UNKNOWN", | |
| 34 "1": "SVG_TRANSFORM_MATRIX", | |
| 35 "2": "SVG_TRANSFORM_TRANSLATE", | |
| 36 "3": "SVG_TRANSFORM_SCALE", | |
| 37 "4": "SVG_TRANSFORM_ROTATE", | |
| 38 "5": "SVG_TRANSFORM_SKEWX", | |
| 39 "6": "SVG_TRANSFORM_SKEWY" | |
| 40 }; | |
| 41 | |
| 42 return "type=" + transformTypes[transform.type] + " matrix=" + dumpMatri x(transform.matrix); | |
| 43 } | |
| 44 | |
| 45 var svg = document.getElementById("svg"); | |
| 46 var circle1 = document.getElementById("circle1"); | |
| 47 var circle2 = document.getElementById("circle2"); | |
| 48 | |
| 49 var transT = svg.createSVGTransform(); | |
|
pdr.
2015/06/12 20:23:24
Nit: no need to abbreviate, lets just call this tr
Shanmuga Pandi
2015/06/13 07:01:31
Done.
| |
| 50 transT.setTranslate(100, 100); | |
| 51 | |
| 52 var scaleS = svg.createSVGTransform(); | |
| 53 scaleS.setScale(3, 3); | |
| 54 | |
| 55 debug("Test applying same transform to many SVGTransformList by appendItem() "); | |
| 56 circle1.transform.baseVal.appendItem(transT); | |
| 57 circle2.transform.baseVal.appendItem(transT); | |
| 58 shouldBe("circle1.transform.baseVal.numberOfItems", "2"); | |
| 59 shouldBe("circle2.transform.baseVal.numberOfItems", "2"); | |
| 60 shouldBeEqualToString("dumpTransform(circle1.transform.baseVal.getItem(1))", "type=SVG_TRANSFORM_TRANSLATE matrix=[1.0 0.0 0.0 1.0 100.0 100.0]"); | |
| 61 shouldBeEqualToString("dumpTransform(circle2.transform.baseVal.getItem(1))", "type=SVG_TRANSFORM_TRANSLATE matrix=[1.0 0.0 0.0 1.0 100.0 100.0]"); | |
| 62 | |
| 63 debug("Test changing SVGTransform value"); | |
| 64 transT.setTranslate(200, 200); | |
| 65 shouldBeEqualToString("dumpTransform(circle1.transform.baseVal.getItem(1))", "type=SVG_TRANSFORM_TRANSLATE matrix=[1.0 0.0 0.0 1.0 200.0 200.0]"); | |
| 66 shouldBeEqualToString("dumpTransform(circle2.transform.baseVal.getItem(1))", "type=SVG_TRANSFORM_TRANSLATE matrix=[1.0 0.0 0.0 1.0 100.0 100.0]"); | |
|
pdr.
2015/06/12 20:23:24
Why is this 1.0 0.0 0.0 1.0 100.0 100.0 instead of
Shanmuga Pandi
2015/06/13 07:01:31
circle1.transform.baseVal.appendItem(transT);
cir
| |
| 67 | |
| 68 | |
| 69 debug("Test applying same transform to many SVGTransformList by insertItemBe fore()"); | |
| 70 circle1.transform.baseVal.insertItemBefore(transT,0); | |
| 71 circle2.transform.baseVal.insertItemBefore(transT,0); | |
| 72 shouldBeEqualToString("dumpTransform(circle1.transform.baseVal.getItem(0))", "type=SVG_TRANSFORM_TRANSLATE matrix=[1.0 0.0 0.0 1.0 200.0 200.0]"); | |
| 73 shouldBeEqualToString("dumpTransform(circle2.transform.baseVal.getItem(0))", "type=SVG_TRANSFORM_TRANSLATE matrix=[1.0 0.0 0.0 1.0 200.0 200.0]"); | |
| 74 shouldBe("circle1.transform.baseVal.numberOfItems", "3"); | |
| 75 shouldBe("circle2.transform.baseVal.numberOfItems", "3"); | |
| 76 | |
| 77 debug("Test applying same transform to many SVGTransformList by replaceItem( )"); | |
| 78 circle1.transform.baseVal.replaceItem(scaleS,2); | |
| 79 circle2.transform.baseVal.replaceItem(scaleS,2); | |
| 80 shouldBeEqualToString("dumpTransform(circle1.transform.baseVal.getItem(2))", "type=SVG_TRANSFORM_SCALE matrix=[3.0 0.0 0.0 3.0 0.0 0.0]"); | |
| 81 shouldBeEqualToString("dumpTransform(circle1.transform.baseVal.getItem(2))", "type=SVG_TRANSFORM_SCALE matrix=[3.0 0.0 0.0 3.0 0.0 0.0]"); | |
|
pdr.
2015/06/12 20:23:24
Was this supposed to be circle2? (here, and line 9
Shanmuga Pandi
2015/06/13 07:01:31
sorry. type error. Corrected
| |
| 82 shouldBe("circle1.transform.baseVal.numberOfItems", "3"); | |
| 83 shouldBe("circle2.transform.baseVal.numberOfItems", "3"); | |
| 84 | |
| 85 | |
| 86 debug("Test applying same transform to many SVGTransformList by initialize() "); | |
| 87 circle1.transform.baseVal.initialize(scaleS); | |
| 88 circle2.transform.baseVal.initialize(scaleS); | |
| 89 shouldBeEqualToString("dumpTransform(circle1.transform.baseVal.getItem(0))", "type=SVG_TRANSFORM_SCALE matrix=[3.0 0.0 0.0 3.0 0.0 0.0]"); | |
| 90 shouldBeEqualToString("dumpTransform(circle1.transform.baseVal.getItem(0))", "type=SVG_TRANSFORM_SCALE matrix=[3.0 0.0 0.0 3.0 0.0 0.0]"); | |
| 91 shouldBe("circle1.transform.baseVal.numberOfItems", "1"); | |
| 92 shouldBe("circle2.transform.baseVal.numberOfItems", "1"); | |
| 93 | |
| 94 ]]> | |
| 95 </script> | |
| 96 </body> | |
| 97 </html> | |
| OLD | NEW |
