Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issue 11773025: cocoa/infobars: Split infobar_controller.* into smaller parts. (Closed)

Created:
7 years, 11 months ago by tfarina
Modified:
7 years, 11 months ago
Reviewers:
sail, Peter Kasting
CC:
chromium-reviews, sail+watch_chromium.org
Visibility:
Public.

Description

cocoa/infobars: Split infobar_controller.* into smaller parts. BUG=164772 R=pkasting@chromium.org,sail@chromium.org TBR=ben@chromium.org # for file additions to gyp files Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175516

Patch Set 1 : #

Patch Set 2 : add includes #

Patch Set 3 : add more necessary includes #

Total comments: 2

Patch Set 4 : add files to chrome_nibs.gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -445 lines) Patch
A chrome/browser/ui/cocoa/infobars/alternate_nav_infobar_controller.h View 1 chunk +15 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/infobars/alternate_nav_infobar_controller.mm View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.h View 1 chunk +18 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm View 1 2 1 chunk +143 lines, -0 lines 0 comments Download
A + chrome/browser/ui/cocoa/infobars/confirm_infobar_controller_unittest.mm View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_controller.h View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_controller.mm View 1 2 chunks +2 lines, -199 lines 0 comments Download
D chrome/browser/ui/cocoa/infobars/infobar_controller_unittest.mm View 1 chunk +0 lines, -232 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/chrome_nibs.gyp View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
Hi guys, could you review this to me? Thanks,
7 years, 11 months ago (2013-01-07 15:32:40 UTC) #1
Peter Kasting
I can't review ObjC, I'll leave this to sail.
7 years, 11 months ago (2013-01-07 17:03:53 UTC) #2
sail
LGTM Thanks for doing this! https://codereview.chromium.org/11773025/diff/7011/chrome/chrome_browser_ui.gypi File chrome/chrome_browser_ui.gypi (right): https://codereview.chromium.org/11773025/diff/7011/chrome/chrome_browser_ui.gypi#newcode571 chrome/chrome_browser_ui.gypi:571: 'browser/ui/cocoa/infobars/alternate_nav_infobar_controller.h', Could you also ...
7 years, 11 months ago (2013-01-07 22:55:24 UTC) #3
tfarina
Thanks! Landing... https://codereview.chromium.org/11773025/diff/7011/chrome/chrome_browser_ui.gypi File chrome/chrome_browser_ui.gypi (right): https://codereview.chromium.org/11773025/diff/7011/chrome/chrome_browser_ui.gypi#newcode571 chrome/chrome_browser_ui.gypi:571: 'browser/ui/cocoa/infobars/alternate_nav_infobar_controller.h', On 2013/01/07 22:55:24, sail wrote: > ...
7 years, 11 months ago (2013-01-08 00:30:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11773025/6016
7 years, 11 months ago (2013-01-08 00:31:26 UTC) #5
commit-bot: I haz the power
Presubmit check for 11773025-6016 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 11 months ago (2013-01-08 00:31:35 UTC) #6
commit-bot: I haz the power
7 years, 11 months ago (2013-01-08 00:35:31 UTC) #7

Powered by Google App Engine
This is Rietveld 408576698