Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1227)

Issue 11773007: Add initial support for handling touch events in desktop chrome AURA. (Closed)

Created:
7 years, 11 months ago by ananta
Modified:
7 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, yusukes+watch_chromium.org, ben+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

Add initial support for handling touch events in desktop chrome AURA. The change in render_widget_host_view_aura.cc is to prevent mouse events generated via touch events on Windows being sent to the renderer. This is necessary as the touch events which are now sent to the renderer ensure that clicks/moves, etc are handled correctly. BUG=168427 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175598

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -5 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 4 3 chunks +5 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_win.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_win.cc View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_win.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/native_widget_win.cc View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 1 2 3 4 3 chunks +36 lines, -2 lines 0 comments Download
M ui/views/win/hwnd_message_handler_delegate.h View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ananta
7 years, 11 months ago (2013-01-04 23:35:49 UTC) #1
sky
https://codereview.chromium.org/11773007/diff/18001/ui/views/widget/native_widget_win.cc File ui/views/widget/native_widget_win.cc (right): https://codereview.chromium.org/11773007/diff/18001/ui/views/widget/native_widget_win.cc#newcode785 ui/views/widget/native_widget_win.cc:785: delegate_->OnTouchEvent(const_cast<ui::TouchEvent*>(&event)); Does this mean windows is now going to ...
7 years, 11 months ago (2013-01-07 15:53:45 UTC) #2
ananta
https://codereview.chromium.org/11773007/diff/18001/ui/views/widget/native_widget_win.cc File ui/views/widget/native_widget_win.cc (right): https://codereview.chromium.org/11773007/diff/18001/ui/views/widget/native_widget_win.cc#newcode785 ui/views/widget/native_widget_win.cc:785: delegate_->OnTouchEvent(const_cast<ui::TouchEvent*>(&event)); On 2013/01/07 15:53:45, sky wrote: > Does this ...
7 years, 11 months ago (2013-01-08 00:50:22 UTC) #3
sky
The TabStrip code likely needs to be updated as the result of this. Please file ...
7 years, 11 months ago (2013-01-08 04:52:13 UTC) #4
ananta
Filed a bug https://code.google.com/p/chromium/issues/detail?id=168829 to track the Tabstrip changes for touch events. https://codereview.chromium.org/11773007/diff/15006/ui/views/widget/native_widget_win.cc File ui/views/widget/native_widget_win.cc ...
7 years, 11 months ago (2013-01-08 18:51:20 UTC) #5
sky
Can you try uploading again, your patch doesn't seem to have made it.
7 years, 11 months ago (2013-01-08 19:13:38 UTC) #6
ananta
On 2013/01/08 19:13:38, sky wrote: > Can you try uploading again, your patch doesn't seem ...
7 years, 11 months ago (2013-01-08 19:14:54 UTC) #7
sky
7 years, 11 months ago (2013-01-08 21:04:12 UTC) #8
LGTM

Powered by Google App Engine
This is Rietveld 408576698