Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 11773003: Introduces message_center_switches.(h|cc) (Closed)

Created:
7 years, 11 months ago by Jun Mukai
Modified:
7 years, 11 months ago
Reviewers:
miket_OOO, dharcourt
CC:
chromium-reviews
Visibility:
Public.

Description

Introduces message_center_switches.(h|cc) The new flag is --enable-new-message-center-popup, due to the discussion of crbug.com/164598 The user code: https://codereview.chromium.org/11773004/ BUG=161052 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175624

Patch Set 1 #

Total comments: 2

Patch Set 2 : --similarity=80 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M ui/message_center/message_center.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A ui/message_center/message_center_switches.h View 1 1 chunk +18 lines, -0 lines 0 comments Download
A ui/message_center/message_center_switches.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jun Mukai
7 years, 11 months ago (2013-01-04 19:18:04 UTC) #1
miket_OOO
lgtm https://codereview.chromium.org/11773003/diff/1/ui/message_center/message_center_switches.h File ui/message_center/message_center_switches.h (right): https://codereview.chromium.org/11773003/diff/1/ui/message_center/message_center_switches.h#newcode5 ui/message_center/message_center_switches.h:5: #ifndef UI_MESSAGE_CENTER_MESSAGE_CENTER_SWITCHES_H_ You should re-upload with --similarity=80 or ...
7 years, 11 months ago (2013-01-07 22:18:35 UTC) #2
dharcourt
lgtm
7 years, 11 months ago (2013-01-07 22:39:15 UTC) #3
Jun Mukai
https://codereview.chromium.org/11773003/diff/1/ui/message_center/message_center_switches.h File ui/message_center/message_center_switches.h (right): https://codereview.chromium.org/11773003/diff/1/ui/message_center/message_center_switches.h#newcode5 ui/message_center/message_center_switches.h:5: #ifndef UI_MESSAGE_CENTER_MESSAGE_CENTER_SWITCHES_H_ On 2013/01/07 22:18:35, miket wrote: > You ...
7 years, 11 months ago (2013-01-07 23:15:01 UTC) #4
commit-bot: I haz the power
7 years, 11 months ago (2013-01-07 23:20:52 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698