Issue 1177233004: Clean up runtime type code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1177233004: Clean up runtime type code (Closed)

Created:
5 years, 6 months ago by vsm

Modified:
5 years, 6 months ago

Reviewers:
Leaf

CC:
dev-compiler+reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Clean up runtime type code R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/e6ae8bd85af87251f7d5f96faebd69ae4d7f74fe

Patch Set 2 : Format #

Total comments: 1

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -20 lines)			Patch
	M	lib/runtime/dart_runtime.js	View	1	5 chunks	+25 lines, -20 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

vsm

https://codereview.chromium.org/1177233004/diff/20001/lib/runtime/dart_runtime.js File lib/runtime/dart_runtime.js (right): https://codereview.chromium.org/1177233004/diff/20001/lib/runtime/dart_runtime.js#newcode163 lib/runtime/dart_runtime.js:163: if (isSubtype(type, core.Iterable) && isSubtype(actual, core.Iterable) || Ideally, this ...

5 years, 6 months ago (2015-06-11 16:30:27 UTC) #2

vsm

5 years, 6 months ago (2015-06-11 16:41:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
e6ae8bd85af87251f7d5f96faebd69ae4d7f74fe (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1177233004: Clean up runtime type code (Closed)

Description

Patch Set 1 #

Patch Set 2 : Format #

Messages