Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1279)

Issue 1177223005: [es6] Ship spread (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)
Modified:
5 years, 6 months ago
Reviewers:
caitp (gmail), rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Ship spread This enables both --harmony-spreadcalls and --harmony-spread-arrays BUG=v8:3018 LOG=N R=caitpotter88@gmail.com, rossberg@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/7876b43bbe0a2bfd43ffda49bf7cb733d92bafdf Cr-Commit-Position: refs/heads/master@{#29168}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/flag-definitions.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
arv (Not doing code reviews)
PTAL
5 years, 6 months ago (2015-06-18 16:06:56 UTC) #1
caitp (gmail)
On 2015/06/18 16:06:56, arv wrote: > PTAL lgtm, for whatever that's worth =) I guess ...
5 years, 6 months ago (2015-06-18 16:33:54 UTC) #2
rossberg
lgtm
5 years, 6 months ago (2015-06-18 19:07:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177223005/1
5 years, 6 months ago (2015-06-19 19:52:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-19 20:40:46 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 20:40:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7876b43bbe0a2bfd43ffda49bf7cb733d92bafdf
Cr-Commit-Position: refs/heads/master@{#29168}

Powered by Google App Engine
This is Rietveld 408576698