content/browser/renderer_host/render_view_host_impl.cc - Issue 11772005: Implement a prototype to render cross-site iframes in a separate process from their parent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 11772005: Implement a prototype to render cross-site iframes in a separate process from their parent. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Removing Task Manager code and fixing issues raised by Charlie. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/plugin_service_impl.cc ('K') | « content/browser/plugin_service_impl.cc ('k') | content/browser/site_per_process_browsertest.cc » ('j') | content/common/browser_plugin_messages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_impl.cc

diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc

index 4ef76db9f0702802353b1b4ec9cf0a2bb14a357b..ff99c20b586f86abb3468e3dba73058232c26782 100644

--- a/content/browser/renderer_host/render_view_host_impl.cc

+++ b/content/browser/renderer_host/render_view_host_impl.cc

@@ -1247,8 +1247,8 @@ void RenderViewHostImpl::OnNavigate(const IPC::Message& msg) {

validated_params.url) ||

static_cast<SiteInstanceImpl*>(GetSiteInstance())->

HasWrongProcessForURL(validated_params.url)) {

- base::KillProcess(process->GetHandle(), RESULT_CODE_KILLED, true);

- UMA_HISTOGRAM_COUNTS("ChildProcess.ViolatedSitePerProcess", 1);

+ // TODO(nasko): Removed the actual kill process call until out-of-process

+ // iframes is ready to go.

}