Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1722)

Unified Diff: content/browser/child_process_security_policy_impl.cc

Issue 11772005: Implement a prototype to render cross-site iframes in a separate process from their parent. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Some cleanup. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/child_process_security_policy_impl.cc
diff --git a/content/browser/child_process_security_policy_impl.cc b/content/browser/child_process_security_policy_impl.cc
index e219bdfac772f9c86fbeb3f37e703b34f2d551c7..51b08cdf48791c461b741e369b3d8a99ebf7e22f 100644
--- a/content/browser/child_process_security_policy_impl.cc
+++ b/content/browser/child_process_security_policy_impl.cc
@@ -508,15 +508,9 @@ bool ChildProcessSecurityPolicyImpl::CanLoadPage(
// stronger security restrictions on page navigation.
if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kSitePerProcess) &&
ResourceType::IsFrame(resource_type)) {
- // TODO(irobert): This currently breaks some WebUI page such as
- // "chrome://extensions/" (belongs to site chrome://chrome/) which
- // will load an iframe for the page "chrome://uber-frame/"
- // (belongs to site chrome://uber-frame/).
- base::AutoLock lock(lock_);
- SecurityStateMap::iterator state = security_state_.find(child_id);
- if (state == security_state_.end())
- return false;
- return state->second->CanLoadPage(url);
+ // TODO(nasko): Do the proper check for site-per-process, once
+ // out-of-process iframes is ready to go.
Charlie Reis 2013/01/17 19:44:54 Wasn't this from your other CL? Did you want to l
nasko 2013/01/17 22:19:13 As discussed, I've decided to drop the other CL an
Charlie Reis 2013/01/18 05:37:07 Ok. In that case, can you add the bug number from
+ return true;
}
return true;
}

Powered by Google App Engine
This is Rietveld 408576698