Implement a prototype to render cross-site iframes in a separate process from their parent.

chrome/browser/task_manager/task_manager_resource_providers.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/task_manager/task_manager_resource_providers.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/file_version_info.h"
 #include "base/i18n/rtl.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/process_util.h"
 #include "base/stl_util.h"
 #include "base/string_util.h"
 #include "base/threading/thread.h"
 #include "base/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/background/background_contents_service.h"
 #include "chrome/browser/background/background_contents_service_factory.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/devtools/devtools_window.h"
 #include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/extensions/extension_process_manager.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system.h"
+#include "chrome/browser/extensions/tab_helper.h"
 #include "chrome/browser/favicon/favicon_tab_helper.h"
 #include "chrome/browser/prerender/prerender_manager.h"
 #include "chrome/browser/prerender/prerender_manager_factory.h"
 #include "chrome/browser/printing/background_printing_manager.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_info_cache.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/tab_contents/background_contents.h"
 #include "chrome/browser/tab_contents/tab_util.h"
 #include "chrome/browser/ui/browser.h"
@@ skipping 1802 matching lines @@
     if (contents &&
         contents->GetRenderProcessHost()->GetID() == render_process_host_id &&
         contents->GetRenderViewHost()->GetRoutingID() == routing_id) {
       return i->second;
     }
   }
 
   return NULL;
 }
 
+// Given a RenderViewHost, return true if this RVH is Cross-site Iframe.

[Charlie Reis, 2013/01/17 19:44:54]

This comment belongs in .h file.

We should have a separate comment within this function saying why the heuristic
it's using (all processes that don't have TabContents) is correct.

Except... it's not correct.  There are other RenderProcessHosts that don't have
TabContents, like background pages and notifications.  We'll need a different
approach.

[nasko, 2013/01/17 22:19:13]

We discussed this in person and both agreed this is the wrong approach. This
code is being removed.

+bool TaskManagerGuestResourceProvider::IsOOPIframe(RenderProcessHost* host) {
+  if (host==NULL || !host->GetHandle())

[Charlie Reis, 2013/01/17 19:44:54]

nit: !host

[nasko, 2013/01/17 22:19:13]

Done.

+    return false;
+
+  for (TabContentsIterator iterator; !iterator.done(); ++iterator) {
+    if ((*iterator)->GetRenderProcessHost()->GetHandle() == host->GetHandle())

[Charlie Reis, 2013/01/17 19:44:54]

Is it possible for this to crash if a TabContents doesn't have a RPH?

[nasko, 2013/01/17 22:19:13]

Done.

+      return false;
+  }
+  return true;
+}
+
 void TaskManagerGuestResourceProvider::StartUpdating() {
   DCHECK(!updating_);
   updating_ = true;
 
   // Add all the existing guest WebContents.
   for (RenderProcessHost::iterator i(
            RenderProcessHost::AllHostsIterator());
        !i.IsAtEnd(); i.Advance()) {
     RenderProcessHost* host = i.GetCurrentValue();
-    if (host->IsGuest()) {
+    if (host->IsGuest() || IsOOPIframe(host)) {
+      // Current RPH only contains Browser-Plugin Guest or Cross-Site IFrame.
       RenderProcessHost::RenderWidgetHostsIterator iter =
           host->GetRenderWidgetHostsIterator();
       for (; !iter.IsAtEnd(); iter.Advance()) {
         const RenderWidgetHost* widget = iter.GetCurrentValue();
-        Add(RenderViewHost::From(
-                const_cast<RenderWidgetHost*>(widget)));
+        Add(RenderViewHost::From(const_cast<RenderWidgetHost*>(widget)));
       }
     }
   }
 
   // Then we register for notifications to get new guests.
   registrar_.Add(this, content::NOTIFICATION_WEB_CONTENTS_CONNECTED,
       content::NotificationService::AllBrowserContextsAndSources());
   registrar_.Add(this, content::NOTIFICATION_WEB_CONTENTS_DISCONNECTED,
       content::NotificationService::AllBrowserContextsAndSources());
 }
@@ skipping 34 matching lines @@
   TaskManagerGuestResource* resource = iter->second;
   task_manager_->RemoveResource(resource);
   resources_.erase(iter);
   delete resource;
 }
 
 void TaskManagerGuestResourceProvider::Observe(int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
   WebContents* web_contents = content::Source<WebContents>(source).ptr();
-  if (!web_contents || !web_contents->GetRenderProcessHost()->IsGuest())
+  if (!web_contents ||
+      (!web_contents->GetRenderProcessHost()->IsGuest() &&
+      !IsOOPIframe(web_contents->GetRenderProcessHost())))
     return;
 
   switch (type) {
     case content::NOTIFICATION_WEB_CONTENTS_CONNECTED:
       Add(web_contents->GetRenderViewHost());
       break;
     case content::NOTIFICATION_WEB_CONTENTS_DISCONNECTED:
       Remove(web_contents->GetRenderViewHost());
       break;
     default:
       NOTREACHED() << "Unexpected notification.";
   }
 }