Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(28)

Issue 1177173007: Templatize FrameSelection::setNonDirectionalSelectionIfNeede function (Closed)

Created:
4 years, 10 months ago by yosin_UTC9
Modified:
4 years, 10 months ago
Reviewers:
tkent
CC:
blink-reviews, hajimehoshi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Templatize FrameSelection::setNonDirectionalSelectionIfNeede function This patch introduces a template function |setNonDirectionalSelectionIfNeedeAlgorithm<Strategy>| to makes |FrameSelection::setNonDirectionalSelectionIfNeede()| function to work both on DOM tree and composed tree with introducing member functions to strategy class |VisibleSelection::InDOMTree|. This patch is result of collaboration work with hajimehoshi@chromium.org for selection of web components. After this patch, we are going to implement another strategies for the composed tree. We've already prepared that at http://crrev.com/1106433002. BUG=275851 TEST=n/a; No behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197326

Patch Set 1 : 2015-06-18T14:23:09 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M Source/core/editing/FrameSelection.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/editing/FrameSelection.cpp View 2 chunks +11 lines, -5 lines 0 comments Download
M Source/core/editing/VisibleSelection.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/VisibleSelection.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
yosin_UTC9
PTAL
4 years, 10 months ago (2015-06-18 06:17:51 UTC) #3
yosin_UTC9
PTAL
4 years, 10 months ago (2015-06-18 07:28:29 UTC) #5
tkent
lgtm
4 years, 10 months ago (2015-06-18 07:41:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177173007/20001
4 years, 10 months ago (2015-06-18 07:42:07 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2015-06-18 07:46:36 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197326

Powered by Google App Engine
This is Rietveld 408576698