Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1177173004: Remove unused SkTypeface_android.h. (Closed)

Created:
5 years, 6 months ago by bungeman-skia
Modified:
5 years, 6 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove unused SkTypeface_android.h. This file had one declaration in it which actually affected the SkFontMgr and had nothing to do with typefaces specifically. As a result, the declaration was moved to SkFontMgr_android.h. Now that the users have been updated, remove this now unused file. Committed: https://skia.googlesource.com/skia/+/7b7c844bca23d92008713e387ae1984dd903f4e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -26 lines) Patch
D include/ports/SkTypeface_android.h View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bungeman-skia
This must wait to land until https://codereview.chromium.org/1181083005/ lands in Chromium.
5 years, 6 months ago (2015-06-17 22:17:59 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177173004/1
5 years, 6 months ago (2015-06-17 22:28:35 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-17 22:40:30 UTC) #6
reed1
lgtm
5 years, 6 months ago (2015-06-18 14:28:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177173004/1
5 years, 6 months ago (2015-06-18 14:46:25 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 14:47:02 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7b7c844bca23d92008713e387ae1984dd903f4e0

Powered by Google App Engine
This is Rietveld 408576698