Issue 1177163004: Improve hash traits for AtomicString

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1177163004: Improve hash traits for AtomicString (Closed)

Created:
4 years, 10 months ago by Mikhail

Modified:
4 years, 10 months ago

Reviewers:
tkent

CC:
blink-reviews, blink-reviews-wtf_chromium.org, Mikhail

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Improve hash traits for AtomicString 1) Provide 'isEmptyValue' function. A simple benchmark shows that 'AtomicString::isNull()' call is approx. 5x faster than comparing to 'nullAtom'. 2) Inherit from SimpleClassHashTraits and thus get rid of repeated code. 3) Remove unneeded "WTF::" Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197409

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -7 lines)			Patch
	M	Source/wtf/text/AtomicStringHash.h	View		1 chunk	+6 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177163004/1

4 years, 10 months ago (2015-06-18 23:31:03 UTC) #5

commit-bot: I haz the power

4 years, 10 months ago (2015-06-18 23:36:17 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197409

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages