Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(28)

Issue 1177163003: Faster WTF::toASCIILower() implementation for 8-bit strings (Closed)

Created:
4 years, 10 months ago by Mikhail
Modified:
4 years, 10 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-wtf_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Faster WTF::toASCIILower() implementation for 8-bit strings WTF::toASCIILower() is used very intensively in various scenarios in blink. This patch adds a table-based implementation of WTF::toASCIILower() for 8-bit strings, on a simple benchmark it is about 5 times faster than the existing implementation. The patch uses http://trac.webkit.org/changeset/181512 by Benjamin Poulain <​bpoulain@apple.com>; Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197025

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Fixed unit test coding style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
M Source/wtf/ASCIICType.h View 1 3 chunks +30 lines, -0 lines 0 comments Download
A Source/wtf/ASCIICTypeTest.cpp View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
M Source/wtf/wtf.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Mikhail
PTAL
4 years, 10 months ago (2015-06-12 07:50:25 UTC) #2
tkent
https://codereview.chromium.org/1177163003/diff/20001/Source/wtf/ASCIICTypeTest.cpp File Source/wtf/ASCIICTypeTest.cpp (right): https://codereview.chromium.org/1177163003/diff/20001/Source/wtf/ASCIICTypeTest.cpp#newcode10 Source/wtf/ASCIICTypeTest.cpp:10: TEST(WTF, ASCIICaseFoldTable) Please change to: namespace WTF { TEST(ASCIICTypeTest, ...
4 years, 10 months ago (2015-06-12 07:55:47 UTC) #3
Mikhail
On 2015/06/12 07:55:47, tkent wrote: > https://codereview.chromium.org/1177163003/diff/20001/Source/wtf/ASCIICTypeTest.cpp > File Source/wtf/ASCIICTypeTest.cpp (right): > > https://codereview.chromium.org/1177163003/diff/20001/Source/wtf/ASCIICTypeTest.cpp#newcode10 > ...
4 years, 10 months ago (2015-06-12 08:04:50 UTC) #4
tkent
lgtm
4 years, 10 months ago (2015-06-12 08:06:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177163003/40001
4 years, 10 months ago (2015-06-12 08:06:37 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2015-06-12 09:44:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197025

Powered by Google App Engine
This is Rietveld 408576698