Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1167)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/thread.cc

Issue 1177153005: Enables clean VM shutdown. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Fix error propagation Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/service_isolate.cc ('k') | runtime/vm/thread_pool.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/thread.cc
diff --git a/runtime/vm/thread.cc b/runtime/vm/thread.cc
index aa4f67ea92a647b00488f466a0e6f9ed26af02e4..3550cf6123b25bf4812bb9fa79cec9c082f0b465 100644
--- a/runtime/vm/thread.cc
+++ b/runtime/vm/thread.cc
@@ -131,9 +131,8 @@ void Thread::EnterIsolate(Isolate* isolate) {
ASSERT(isolate->thread_state() == NULL);
InterruptableThreadState* thread_state =
ThreadInterrupter::GetCurrentThreadState();
-#if defined(DEBUG)
- Isolate::CheckForDuplicateThreadState(thread_state);
-#endif
+ // TODO(koda): Calling Isolate::CheckForDuplicateThreadState(thread_state)
+ // here can lead to deadlock. Evaluate doing this check some other way.
ASSERT(thread_state != NULL);
Profiler::BeginExecution(isolate);
isolate->set_thread_state(thread_state);
« no previous file with comments | « runtime/vm/service_isolate.cc ('k') | runtime/vm/thread_pool.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698