Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/bin/vmservice/vmservice_io.dart

Issue 1177153005: Enables clean VM shutdown. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Remove debug print Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/run_vm_tests.cc ('k') | runtime/include/dart_api.h » ('j') | runtime/include/dart_native_api.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice/vmservice_io.dart
diff --git a/runtime/bin/vmservice/vmservice_io.dart b/runtime/bin/vmservice/vmservice_io.dart
index 409bc5972a0c110d842c0da006e319a958bef8ff..631cf8d5e277aa36fc5fa5ada52123a162b1e9f4 100644
--- a/runtime/bin/vmservice/vmservice_io.dart
+++ b/runtime/bin/vmservice/vmservice_io.dart
@@ -89,6 +89,14 @@ main() {
// scheduled microtasks.
Timer.run(() {});
}
+ // TODO(johnmccutchan, turnidge) Creating a VMService object here causes
+ // strange behavior from the legacy debug protocal and coverage tool.
+ // Enable this code, and remove the call to Isoate::KillIsolate() from
turnidge 2015/08/04 21:39:02 protocal -> protocol, Isoate -> Isolate.
zra 2015/08/05 06:23:06 Done and added link to issue.
+ // service_isolate.cc when the strange behavior is solved.
+ // else {
+ // var service = new VMService();
+ // service.onShutdown = _onShutdown;
+ // }
scriptLoadPort.handler = _processLoadRequest;
// Register signal handler after a small delay to avoid stalling main
// isolate startup.
« no previous file with comments | « runtime/bin/run_vm_tests.cc ('k') | runtime/include/dart_api.h » ('j') | runtime/include/dart_native_api.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698