Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 117713003: Add encoding info for those WebUI pages that were missing it. (Closed)

Created:
7 years ago by Nikita (slow)
Modified:
7 years ago
CC:
chromium-reviews, skanuj+watch_chromium.org, nkostylev+watch_chromium.org, tzik, shishir+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, arv+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, melevin+watch_chromium.org, dominich, pedrosimonetti+watch_chromium.org, dbeam+watch-ntp_chromium.org, nhiroki, jfweitz+watch_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, estade+watch_chromium.org, Jered, tfarina, donnd+watch_chromium.org, dominich+watch_chromium.org, eroman, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, mmenke
Visibility:
Public.

Description

Add encoding info for those WebUI pages that were missing it. Prevents encoding detection issues on those pages. BUG=329890 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241926

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M chrome/browser/resources/about_flash.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/about_memory.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/about_memory_linux.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/about_memory_mac.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/about_nacl.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/about_stats.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/about_version.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/bookmark_manager/main.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/bluetooth_pair_device.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/charger_replacement.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/choose_mobile_network.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/guest_session_tab.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/demo_user_login.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/login.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/network_configuration/config.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/network_configuration/status.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/notification_icon_link.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/offline_app_load.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/proxy_settings.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/sim_unlock.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/slow.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/wallpaper_manager/main.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/enhanced_bookmark_manager/main.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/http_auth.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/local_ntp/local_ntp.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/managed_mode_block_interstitial.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/net_internals/index.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/notification_1line.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/notification_2line.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/notification_icon.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/ntp4/guest_tab.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/ntp4/incognito_tab.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/predictors/predictors.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/quota_internals/main.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/reader_out_of_date.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/safe_browsing_multiple_threat_block.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/signin_internals/signin_index.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/ssl/blocking.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/sync_file_system_internals/main.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/sync_internals/sync_index.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/tab_modal_confirm_dialog.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/user_manager/user_manager.html View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nikita (slow)
7 years ago (2013-12-19 16:33:56 UTC) #1
Denis Kuznetsov (DE-MUC)
Make sure that meta is always first element in head (title can depend on encoding)
7 years ago (2013-12-19 16:38:52 UTC) #2
Nikita (slow)
On 2013/12/19 16:38:52, Denis Kuznetsov wrote: > Make sure that meta is always first element ...
7 years ago (2013-12-19 16:44:42 UTC) #3
Denis Kuznetsov (DE-MUC)
lgtm
7 years ago (2013-12-19 16:52:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/117713003/20001
7 years ago (2013-12-19 16:54:58 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-19 20:07:08 UTC) #6
Message was sent while issue was closed. 
Change committed as 241926

Powered by Google App Engine
This is Rietveld 408576698