Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: Source/core/layout/HitTestResult.h

Issue 1177123003: Revert "Implement a Hit Test Cache for same point hits." (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/layout/HitTestRequest.h ('k') | Source/core/layout/HitTestResult.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/HitTestResult.h
diff --git a/Source/core/layout/HitTestResult.h b/Source/core/layout/HitTestResult.h
index dea3ffbedf7882a27a437861d505c28e3182bfcf..01127a7ecd36ce969ce251bf51e202cc8a8e05e0 100644
--- a/Source/core/layout/HitTestResult.h
+++ b/Source/core/layout/HitTestResult.h
@@ -49,8 +49,7 @@ class PositionWithAffinity;
class Scrollbar;
class CORE_EXPORT HitTestResult {
- ALLOW_ONLY_INLINE_ALLOCATION();
-
+ DISALLOW_ALLOCATION();
public:
typedef WillBeHeapListHashSet<RefPtrWillBeMember<Node>> NodeSet;
@@ -64,14 +63,6 @@ public:
HitTestResult& operator=(const HitTestResult&);
DECLARE_TRACE();
- bool equalForCacheability(const HitTestResult&) const;
- void cacheValues(const HitTestResult&);
-
- // Populate this object based on another HitTestResult; similar to assignment operator
- // but don't assign any of the request parameters. ie. Thie method avoids setting
- // |m_hitTestLocation|, |m_hitTestRequest|.
- void populateFromCachedResult(const HitTestResult&);
-
// For point-based hit tests, these accessors provide information about the node
// under the point. For rect-based hit tests they are meaningless (reflect the
// last candidate node observed in the rect).
@@ -133,9 +124,6 @@ public:
bool isOverLink() const;
- const LayoutRect& validityRect() const { return m_validityRect; }
- void setValidityRect(const LayoutRect&);
-
// Return true if the test is a list-based test and we should continue testing.
bool addNodeToListBasedTestResult(Node*, const HitTestLocation& pointInContainer, const LayoutRect& = LayoutRect());
bool addNodeToListBasedTestResult(Node*, const HitTestLocation& pointInContainer, const FloatRect&);
@@ -155,7 +143,6 @@ private:
HitTestLocation m_hitTestLocation;
HitTestRequest m_hitTestRequest;
- LayoutRect m_validityRect;
RefPtrWillBeMember<Node> m_innerNode;
RefPtrWillBeMember<Node> m_innerPossiblyPseudoNode;
« no previous file with comments | « Source/core/layout/HitTestRequest.h ('k') | Source/core/layout/HitTestResult.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698