Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(57)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1177123003: Revert "Implement a Hit Test Cache for same point hits." (Closed)

Created:
4 years, 10 months ago by dtapuska
Modified:
4 years, 10 months ago
Reviewers:
Rick Byers
CC:
blink-reviews, vivekg_samsung, dshwang, eae+blinkwatch, vivekg, rwlbuis, pdr+graphicswatchlist_chromium.org, arv+blink, szager+layoutwatch_chromium.org, Justin Novosad, danakj, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, jchaffraix+rendering, blink-reviews-paint_chromium.org, zoltan1, sof, jbroman, krit, blink-reviews-rendering, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, slimming-paint-reviews_chromium.org, f(malita), Inactive, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert "Implement a Hit Test Cache for same point hits." This reverts commit edbe6b416429926ef2a111ea57453cf569eb7dfe. Revert the Hit Test Cache as it was causing a few flaky test failures while I investigate the source of the issue. BUG=500514 TBR=esprehn@chromium.org R=rbyers@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197116

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -597 lines) Patch
D LayoutTests/fast/events/hit-test-cache.html View 1 chunk +0 lines, -110 lines 0 comments Download
D LayoutTests/fast/events/hit-test-cache-expected.txt View 1 chunk +0 lines, -53 lines 0 comments Download
M LayoutTests/fast/events/hit-test-counts.html View 5 chunks +3 lines, -23 lines 0 comments Download
M LayoutTests/fast/events/hit-test-counts-expected.txt View 1 chunk +60 lines, -66 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/TreeScope.h View 5 chunks +2 lines, -5 lines 0 comments Download
M Source/core/dom/TreeScope.cpp View 2 chunks +3 lines, -12 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D Source/core/layout/HitTestCache.h View 1 chunk +0 lines, -84 lines 0 comments Download
D Source/core/layout/HitTestCache.cpp View 1 chunk +0 lines, -80 lines 0 comments Download
M Source/core/layout/HitTestRequest.h View 2 chunks +0 lines, -12 lines 0 comments Download
M Source/core/layout/HitTestResult.h View 4 chunks +1 line, -14 lines 0 comments Download
M Source/core/layout/HitTestResult.cpp View 3 chunks +2 lines, -31 lines 0 comments Download
M Source/core/layout/LayoutImage.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/layout/LayoutPart.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/layout/LayoutView.h View 3 chunks +1 line, -7 lines 0 comments Download
M Source/core/layout/LayoutView.cpp View 4 chunks +9 lines, -22 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayer.cpp View 5 chunks +5 lines, -10 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +0 lines, -35 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/platform/LayoutUnit.h View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/platform/geometry/LayoutRect.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/platform/geometry/LayoutRect.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M public/platform/WebLayer.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Rick Byers
Rubber stamp LGTM for revert
4 years, 10 months ago (2015-06-15 15:02:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177123003/1
4 years, 10 months ago (2015-06-15 15:03:39 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2015-06-15 15:04:59 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197116

Powered by Google App Engine
This is Rietveld 408576698