Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 1177103003: Use LookupIterator for elements in the observed part of DefineAccessor (Closed)

Created:
5 years, 6 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use LookupIterator for elements in the observed part of DefineAccessor BUG=v8:4137 LOG=n Committed: https://crrev.com/83abd09597039c7122e1aab1bfa8851cf0c60110 Cr-Commit-Position: refs/heads/master@{#28963}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Extend LookupIterator for simplification and bugfixing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -44 lines) Patch
M src/objects.cc View 1 2 3 chunks +21 lines, -44 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Toon Verwaest
ptal
5 years, 6 months ago (2015-06-11 10:52:07 UTC) #2
Toon Verwaest
ptal
5 years, 6 months ago (2015-06-11 10:52:36 UTC) #4
Toon Verwaest
ptal
5 years, 6 months ago (2015-06-11 10:52:54 UTC) #5
Jakob Kummerow
https://codereview.chromium.org/1177103003/diff/20001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1177103003/diff/20001/src/objects.cc#newcode6408 src/objects.cc:6408: CHECK(GetPropertyAttributes(&it).IsJust()); I'm not a fan of having a Release-mode ...
5 years, 6 months ago (2015-06-11 11:14:28 UTC) #6
Jakob Kummerow
lgtm
5 years, 6 months ago (2015-06-11 11:18:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177103003/40001
5 years, 6 months ago (2015-06-11 16:12:24 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-11 20:09:23 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 20:09:37 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/83abd09597039c7122e1aab1bfa8851cf0c60110
Cr-Commit-Position: refs/heads/master@{#28963}

Powered by Google App Engine
This is Rietveld 408576698