Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 1177083003: Reland "Keep track of array buffers in new space separately" (Closed)

Created:
5 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Keep track of array buffers in new space separately" Original review https://codereview.chromium.org/1133773002/ BUG=v8:3996 TBR=hpayer@chromium.org LOG=n Committed: https://crrev.com/89b9a2cfb317e52186f682c91502b22932d52db3 Cr-Commit-Position: refs/heads/master@{#28987}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -37 lines) Patch
M src/api.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/heap/heap.h View 3 chunks +40 lines, -5 lines 0 comments Download
M src/heap/heap.cc View 1 6 chunks +115 lines, -25 lines 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +6 lines, -1 line 0 comments Download
M src/heap/objects-visiting-inl.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-typedarray.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177083003/20001
5 years, 6 months ago (2015-06-12 08:24:57 UTC) #2
jochen (gone - plz use gerrit)
i wonder why this didn't explode before. guess we should merge this back
5 years, 6 months ago (2015-06-12 08:25:06 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-12 09:34:44 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/89b9a2cfb317e52186f682c91502b22932d52db3 Cr-Commit-Position: refs/heads/master@{#28987}
5 years, 6 months ago (2015-06-12 09:35:01 UTC) #5
jochen (gone - plz use gerrit)
5 years, 6 months ago (2015-06-14 18:23:00 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1186613007/ by jochen@chromium.org.

The reason for reverting is: Still broken.

Powered by Google App Engine
This is Rietveld 408576698