Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: extensions/renderer/resources/media_router_bindings.js

Issue 1177073003: [MediaRouter] Update MR-2-Extension's PostMessage to return boolean. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rename SendMessage to SendRouteMessage Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media/router/test_helper.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/resources/media_router_bindings.js
diff --git a/extensions/renderer/resources/media_router_bindings.js b/extensions/renderer/resources/media_router_bindings.js
index f28c354d2df7241a7ed0571a243be1b7e2a13884..368b56699b536a93d5ad914e7f0e2462a2802efd 100644
--- a/extensions/renderer/resources/media_router_bindings.js
+++ b/extensions/renderer/resources/media_router_bindings.js
@@ -304,9 +304,9 @@ define('media_router_bindings', [
this.stopObservingMediaSinks = null;
/**
- * @type {function(string, string, string)}
+ * @type {function(string, string)}
*/
- this.postMessage = null;
+ this.sendRouteMessage = null;
/**
* @type {function()}
@@ -353,7 +353,7 @@ define('media_router_bindings', [
var requiredHandlers = [
'stopObservingMediaRoutes',
'startObservingMediaRoutes',
- 'postMessage',
+ 'sendRouteMessage',
'closeRoute',
'joinRoute',
'createRoute',
@@ -448,12 +448,17 @@ define('media_router_bindings', [
* Posts a message to the route designated by |routeId|.
* @param {!string} routeId
* @param {!string} message
- * @param {string} extraInfoJson
+ * @return {!Promise.<boolean>} Resolved with true if the message was sent,
+ * or false on failure.
*/
- MediaRouter.prototype.postMessage = function(
- routeId, message, extraInfoJson) {
- // TODO(mfoltz): Remove extraInfoJson if no longer needed.
- this.handlers_.postMessage(routeId, message, JSON.parse(extraInfoJson));
+ MediaRouter.prototype.sendRouteMessage = function(
+ routeId, message) {
+ this.handlers_.sendRouteMessage(routeId, message)
+ .then(function() {
+ return true;
+ }, function() {
+ return false;
+ });
};
/**
« no previous file with comments | « chrome/browser/media/router/test_helper.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698