[MediaRouter] Update MR-2-Extension's PostMessage to return boolean.

extensions/renderer/resources/media_router_bindings.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var mediaRouterObserver;
 
 define('media_router_bindings', [
     'mojo/public/js/bindings',
     'mojo/public/js/core',
     'content/public/renderer/service_provider',
@@ skipping 286 matching lines @@
      * @type {function(string)}
      */
     this.startObservingMediaSinks = null;
 
     /**
      * @type {function(string)}
      */
     this.stopObservingMediaSinks = null;
 
     /**
-     * @type {function(string, string, string)}
+     * @type {function(string, string)}
      */
-    this.postMessage = null;
+    this.sendMessage = null;
 
     /**
      * @type {function()}
      */
     this.startObservingMediaRoutes = null;
 
     /**
      * @type {function()}
      */
     this.stopObservingMediaRoutes = null;
@@ skipping 26 matching lines @@
    * Sets the callback handler used to invoke methods in the provider manager.
    *
    * TODO(mfoltz): Rename to something more explicit?
    * @param {!MediaRouterHandlers} handlers
    */
   MediaRouter.prototype.setHandlers = function(handlers) {
     this.handlers_ = handlers;
     var requiredHandlers = [
       'stopObservingMediaRoutes',
       'startObservingMediaRoutes',
-      'postMessage',
+      'sendMessage',
       'closeRoute',
       'joinRoute',
       'createRoute',
       'stopObservingMediaSinks',
       'startObservingMediaRoutes'
     ];
     requiredHandlers.forEach(function(nextHandler) {
       if (!handlers.hasOwnProperty(nextHandler)) {
         console.error(nextHandler + ' handler not registered.');
       }
@@ skipping 74 matching lines @@
    * @param {!string} routeId
    */
   MediaRouter.prototype.closeRoute = function(routeId) {
     this.handlers_.closeRoute(routeId);
   };
 
   /**
    * Posts a message to the route designated by |routeId|.
    * @param {!string} routeId
    * @param {!string} message
-   * @param {string} extraInfoJson
+   * @return {!Promise.<boolean>} Resolved with true if the message was sent,
+   *  or false on failure.

[Ken Rockot(use gerrit already), 2015/06/11 21:22:04]

super nitty style nit: should indent 4 spaces from the @

  * @return ...
  *     or false ...

[haibinlu, 2015/06/11 22:46:23]

Done.

    */
-  MediaRouter.prototype.postMessage = function(
-      routeId, message, extraInfoJson) {
-    // TODO(mfoltz): Remove extraInfoJson if no longer needed.
-    this.handlers_.postMessage(routeId, message, JSON.parse(extraInfoJson));
+  MediaRouter.prototype.sendMessage = function(

[mark a. foltz, 2015/06/11 18:48:33]

It seems odd that the Promise should be resolved here.  Perhaps this function
should return the Promise to the caller so it can chain off of it.

[Ken Rockot(use gerrit already), 2015/06/11 21:22:04]

I agree. A Promise resolving/rejecting is effectively already a boolean result,
so doing this only serves to hide potential failure details in case of
rejection.

[haibinlu, 2015/06/11 22:46:23]

For mojo method that returns a value,  mojo generates Promise as return value at
Javascript side, and callback at c++ side. I did not find a way to tell mojo how
to convert a rejected promise into proper return value for the callback.

+      routeId, message) {
+    this.handlers_.sendMessage(routeId, message)
+        .then(function() {
+          return true;
+        }, function() {
+          return false;
+        });
   };
 
   /**
    * Requests that the provider manager start sending information about active
    * media routes to the Media Router.
    */
   MediaRouter.prototype.startObservingMediaRoutes = function() {
     this.handlers_.startObservingMediaRoutes();
   };
 
   /**
    * Requests that the provider manager stop sending information about active
    * media routes to the Media Router.
    */
   MediaRouter.prototype.stopObservingMediaRoutes = function() {
     this.handlers_.stopObservingMediaRoutes();
   };
 
   mediaRouterObserver = new MediaRouterObserver(connector.bindHandleToProxy(
       serviceProvider.connectToService(
           mediaRouterMojom.MediaRouterObserver.name),
       mediaRouterMojom.MediaRouterObserver));
 
   return mediaRouterObserver;
 });