Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: test/mjsunit/es6/block-for.js

Issue 1177053006: [es6] Fix completion values of for loops with lexical variables (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: offline feedback Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/rewriter.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 let a = []; 151 let a = [];
152 for (let i = 0; i < 5; a.push(function () { return i; }), ++i) { } 152 for (let i = 0; i < 5; a.push(function () { return i; }), ++i) { }
153 for (let k = 0; k < 5; ++k) { 153 for (let k = 0; k < 5; ++k) {
154 assertEquals(k + 1, a[k]()); 154 assertEquals(k + 1, a[k]());
155 } 155 }
156 } 156 }
157 closure_in_for_next(); 157 closure_in_for_next();
158 158
159 159
160 // In a for-in statement the iteration variable is fresh 160 // In a for-in statement the iteration variable is fresh
161 // for earch iteration. 161 // for each iteration.
162 function closures3(x) { 162 function closures3(x) {
163 let a = []; 163 let a = [];
164 for (let p in x) { 164 for (let p in x) {
165 a.push(function () { return p; }); 165 a.push(function () { return p; });
166 } 166 }
167 let k = 0; 167 let k = 0;
168 for (let q in x) { 168 for (let q in x) {
169 assertEquals(q, a[k]()); 169 assertEquals(q, a[k]());
170 ++k; 170 ++k;
171 } 171 }
172 } 172 }
173 closures3({a : [0], b : 1, c : {v : 1}, get d() {}, set e(x) {}}); 173 closures3({a : [0], b : 1, c : {v : 1}, get d() {}, set e(x) {}});
174
175 // Check normal for statement completion values.
176 assertEquals(1, eval("for (let i = 0; i < 10; i++) { 1; }"));
177 assertEquals(9, eval("for (let i = 0; i < 10; i++) { i; }"));
178 assertEquals(undefined, eval("for (let i = 0; false;) { }"));
179 assertEquals(undefined, eval("for (const i = 0; false;) { }"));
180 assertEquals(undefined, eval("for (let i = 0; i < 10; i++) { }"));
181 assertEquals(undefined, eval("for (let i = 0; false;) { i; }"));
182 assertEquals(undefined, eval("for (const i = 0; false;) { i; }"));
183 assertEquals(undefined, eval("for (let i = 0; true;) { break; }"));
184 assertEquals(undefined, eval("for (const i = 0; true;) { break; }"));
185 assertEquals(undefined, eval("for (let i = 0; i < 10; i++) { continue; }"));
186 assertEquals(undefined, eval("for (let i = 0; true;) { break; i; }"));
187 assertEquals(undefined, eval("for (const i = 0; true;) { break; i; }"));
188 assertEquals(undefined, eval("for (let i = 0; i < 10; i++) { continue; i; }"));
189 assertEquals(0, eval("for (let i = 0; true;) { i; break; }"));
190 assertEquals(0, eval("for (const i = 0; true;) { i; break; }"));
191 assertEquals(9, eval("for (let i = 0; i < 10; i++) { i; continue; }"));
192 assertEquals(3, eval("for (let i = 0; true; i++) { i; if (i >= 3) break; }"));
193 assertEquals(2, eval("for (let i = 0; true; i++) { if (i >= 3) break; i; }"));
194 assertEquals(
195 2, eval("for (let i = 0; i < 10; i++) { if (i >= 3) continue; i; }"));
196 assertEquals(undefined, eval("foo: for (let i = 0; true;) { break foo; }"));
197 assertEquals(undefined, eval("foo: for (const i = 0; true;) { break foo; }"));
198 assertEquals(3, eval("foo: for (let i = 3; true;) { i; break foo; }"));
OLDNEW
« no previous file with comments | « src/rewriter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698