[SP] Add a drawing recorder before painting caps lock indicator in password fields.

Source/core/layout/LayoutTextControlSingleLine.cpp

 /**
  * Copyright (C) 2006, 2007, 2010 Apple Inc. All rights reserved.
  *           (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 16 matching lines @@
 #include "core/CSSValueKeywords.h"
 #include "core/InputTypeNames.h"
 #include "core/dom/shadow/ShadowRoot.h"
 #include "core/editing/FrameSelection.h"
 #include "core/frame/LocalFrame.h"
 #include "core/html/shadow/ShadowElementNames.h"
 #include "core/layout/HitTestResult.h"
 #include "core/layout/LayoutAnalyzer.h"
 #include "core/layout/LayoutTheme.h"
 #include "core/paint/DeprecatedPaintLayer.h"
+#include "core/paint/LayoutObjectDrawingRecorder.h"
 #include "core/paint/PaintInfo.h"
 #include "core/paint/ThemePainter.h"
 #include "platform/PlatformKeyboardEvent.h"
 #include "platform/fonts/SimpleFontData.h"
 
 namespace blink {
 
 using namespace HTMLNames;
 
 LayoutTextControlSingleLine::LayoutTextControlSingleLine(HTMLInputElement* element)
@@ skipping 30 matching lines @@
         LayoutRect contentsRect = contentBoxRect();
 
         // Center in the block progression direction.
         if (isHorizontalWritingMode())
             contentsRect.setY((size().height() - contentsRect.height()) / 2);
         else
             contentsRect.setX((size().width() - contentsRect.width()) / 2);
 
         // Convert the rect into the coords used for painting the content
         contentsRect.moveBy(paintOffset + location());
-        LayoutTheme::theme().painter().paintCapsLockIndicator(this, paintInfo, pixelSnappedIntRect(contentsRect));
+        IntRect snappedRect = pixelSnappedIntRect(contentsRect);
+        LayoutObjectDrawingRecorder recorder(*paintInfo.context, *this, paintInfo.phase, snappedRect);

[chrishtr, 2015/06/18 20:09:02]

visual overflow rect instead?

[wkorman, 2015/06/18 22:26:04]

Discussed in person, sticking with contentsRect as it's been transformed and
should be what's needed for this case. We have risk if painting this ends up
making use of the visual overflow rect down the line, but let's cross that
bridge if we come to it.

+        LayoutTheme::theme().painter().paintCapsLockIndicator(this, paintInfo, snappedRect);
     }
 }
 
 LayoutUnit LayoutTextControlSingleLine::computeLogicalHeightLimit() const
 {
     return containerElement() ? contentLogicalHeight() : logicalHeight();
 }
 
 void LayoutTextControlSingleLine::layout()
 {
@@ skipping 341 matching lines @@
     if (innerEditorElement())
         innerEditorElement()->setScrollTop(newTop);
 }
 
 HTMLInputElement* LayoutTextControlSingleLine::inputElement() const
 {
     return toHTMLInputElement(node());
 }
 
 }