Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1177043014: Fix broken link and add cross-compiling to quick start (Closed)

Created:
5 years, 6 months ago by dmazzoni
Modified:
5 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix broken link and add cross-compiling to quick start BUG=none Committed: https://crrev.com/925b216305900e3aa7422f46d6c623a096dc3eec Cr-Commit-Position: refs/heads/master@{#339100}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add spaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M tools/gn/docs/faq.md View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/docs/quick_start.md View 1 1 chunk +16 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
dmazzoni
If you don't want it in quick start, what about including cross-compiling info in the ...
5 years, 6 months ago (2015-06-17 21:49:06 UTC) #2
brettw
Seems good, LGTM https://codereview.chromium.org/1177043014/diff/1/tools/gn/docs/quick_start.md File tools/gn/docs/quick_start.md (right): https://codereview.chromium.org/1177043014/diff/1/tools/gn/docs/quick_start.md#newcode59 tools/gn/docs/quick_start.md:59: target_os="chromeos" Can you put spaces on ...
5 years, 6 months ago (2015-06-19 17:47:06 UTC) #3
dmazzoni
https://codereview.chromium.org/1177043014/diff/1/tools/gn/docs/quick_start.md File tools/gn/docs/quick_start.md (right): https://codereview.chromium.org/1177043014/diff/1/tools/gn/docs/quick_start.md#newcode59 tools/gn/docs/quick_start.md:59: target_os="chromeos" On 2015/06/19 17:47:06, brettw wrote: > Can you ...
5 years, 5 months ago (2015-07-16 19:30:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177043014/20001
5 years, 5 months ago (2015-07-16 19:31:55 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-16 19:46:10 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 19:47:17 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/925b216305900e3aa7422f46d6c623a096dc3eec
Cr-Commit-Position: refs/heads/master@{#339100}

Powered by Google App Engine
This is Rietveld 408576698