Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: src/objects.h

Issue 1177043012: More cleanly separate adding from setting elements (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/lookup.cc ('K') | « src/lookup.cc ('k') | src/objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index f5ce1d6c4251ff0582b4ec7fa7d1cb10aea7ff21..462e7aa97698325e9dd6da942029b8dc05dcba59 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -1893,6 +1893,12 @@ class JSObject: public JSReceiver {
static void SetNormalizedProperty(Handle<JSObject> object, Handle<Name> name,
Handle<Object> value,
PropertyDetails details);
+ static void AddDictionaryElement(Handle<JSObject> object, uint32_t index,
+ Handle<Object> value,
+ PropertyAttributes attributes);
+ static void AddSloppyArgumentsElement(Handle<JSObject> object, uint32_t index,
+ Handle<Object> value,
+ PropertyAttributes attributes);
static void SetDictionaryElement(Handle<JSObject> object, uint32_t index,
Handle<Object> value,
PropertyAttributes attributes);
@@ -1900,9 +1906,9 @@ class JSObject: public JSReceiver {
Handle<Object> value,
PropertyAttributes attributes);
- static void SetFastElement(Handle<JSObject> object, uint32_t index,
+ static void AddFastElement(Handle<JSObject> object, uint32_t index,
Handle<Object> value);
- static void SetFastDoubleElement(Handle<JSObject> object, uint32_t index,
+ static void AddFastDoubleElement(Handle<JSObject> object, uint32_t index,
Handle<Object> value);
static void OptimizeAsPrototype(Handle<JSObject> object,
« src/lookup.cc ('K') | « src/lookup.cc ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698