Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/objects.h

Issue 1177043012: More cleanly separate adding from setting elements (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rename Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/lookup.cc ('k') | src/objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_OBJECTS_H_ 5 #ifndef V8_OBJECTS_H_
6 #define V8_OBJECTS_H_ 6 #define V8_OBJECTS_H_
7 7
8 #include <iosfwd> 8 #include <iosfwd>
9 9
10 #include "src/allocation.h" 10 #include "src/allocation.h"
(...skipping 1875 matching lines...) Expand 10 before | Expand all | Expand 10 after
1886 1886
1887 // Migrates the given object only if the target map is already available, 1887 // Migrates the given object only if the target map is already available,
1888 // or returns false if such a map is not yet available. 1888 // or returns false if such a map is not yet available.
1889 static bool TryMigrateInstance(Handle<JSObject> instance); 1889 static bool TryMigrateInstance(Handle<JSObject> instance);
1890 1890
1891 // Sets the property value in a normalized object given (key, value, details). 1891 // Sets the property value in a normalized object given (key, value, details).
1892 // Handles the special representation of JS global objects. 1892 // Handles the special representation of JS global objects.
1893 static void SetNormalizedProperty(Handle<JSObject> object, Handle<Name> name, 1893 static void SetNormalizedProperty(Handle<JSObject> object, Handle<Name> name,
1894 Handle<Object> value, 1894 Handle<Object> value,
1895 PropertyDetails details); 1895 PropertyDetails details);
1896 static void AddDictionaryElement(Handle<JSObject> object, uint32_t index,
1897 Handle<Object> value,
1898 PropertyAttributes attributes);
1899 static void AddSloppyArgumentsElement(Handle<JSObject> object, uint32_t index,
1900 Handle<Object> value,
1901 PropertyAttributes attributes);
1896 static void SetDictionaryElement(Handle<JSObject> object, uint32_t index, 1902 static void SetDictionaryElement(Handle<JSObject> object, uint32_t index,
1897 Handle<Object> value, 1903 Handle<Object> value,
1898 PropertyAttributes attributes); 1904 PropertyAttributes attributes);
1899 static void SetSloppyArgumentsElement(Handle<JSObject> object, uint32_t index, 1905 static void SetDictionaryArgumentsElement(Handle<JSObject> object,
1900 Handle<Object> value, 1906 uint32_t index,
1901 PropertyAttributes attributes); 1907 Handle<Object> value,
1908 PropertyAttributes attributes);
1902 1909
1903 static void SetFastElement(Handle<JSObject> object, uint32_t index, 1910 static void AddFastElement(Handle<JSObject> object, uint32_t index,
1904 Handle<Object> value); 1911 Handle<Object> value);
1905 static void SetFastDoubleElement(Handle<JSObject> object, uint32_t index, 1912 static void AddFastDoubleElement(Handle<JSObject> object, uint32_t index,
1906 Handle<Object> value); 1913 Handle<Object> value);
1907 1914
1908 static void OptimizeAsPrototype(Handle<JSObject> object, 1915 static void OptimizeAsPrototype(Handle<JSObject> object,
1909 PrototypeOptimizationMode mode); 1916 PrototypeOptimizationMode mode);
1910 static void ReoptimizeIfPrototype(Handle<JSObject> object); 1917 static void ReoptimizeIfPrototype(Handle<JSObject> object);
1911 static void LazyRegisterPrototypeUser(Handle<Map> user, Isolate* isolate); 1918 static void LazyRegisterPrototypeUser(Handle<Map> user, Isolate* isolate);
1912 static bool RegisterPrototypeUserIfNotRegistered(Handle<JSObject> prototype, 1919 static bool RegisterPrototypeUserIfNotRegistered(Handle<JSObject> prototype,
1913 Handle<HeapObject> user, 1920 Handle<HeapObject> user,
1914 Isolate* isolate); 1921 Isolate* isolate);
1915 static bool UnregisterPrototypeUser(Handle<JSObject> prototype, 1922 static bool UnregisterPrototypeUser(Handle<JSObject> prototype,
(...skipping 8956 matching lines...) Expand 10 before | Expand all | Expand 10 after
10872 } else { 10879 } else {
10873 value &= ~(1 << bit_position); 10880 value &= ~(1 << bit_position);
10874 } 10881 }
10875 return value; 10882 return value;
10876 } 10883 }
10877 }; 10884 };
10878 10885
10879 } } // namespace v8::internal 10886 } } // namespace v8::internal
10880 10887
10881 #endif // V8_OBJECTS_H_ 10888 #endif // V8_OBJECTS_H_
OLDNEW
« no previous file with comments | « src/lookup.cc ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698