More cleanly separate adding from setting elements

More cleanly separate adding from setting elements

This is a first step towards disentangling the backend code. In the future we should just use ElementsAccessors.
BUG=v8:4137
LOG=n

Committed: https://crrev.com/6a3ba3cc2ce4bec497ea59b925ab4b2280b0f048
Cr-Commit-Position: refs/heads/master@{#29111}

[Toon Verwaest, 2015-06-17 18:54:43]

verwaest@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Toon Verwaest, 2015-06-17 18:54:44]

ptal

[Jakob Kummerow, 2015-06-18 11:32:47]

LGTM with nits.

https://codereview.chromium.org/1177043012/diff/60001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1177043012/diff/60001/src/objects.cc#newcode1...
src/objects.cc:12555: :
Handle<Object>::cast(isolate->factory()->the_hole_value());
nit: do you even need the cast?

https://codereview.chromium.org/1177043012/diff/60001/src/objects.cc#newcode1...
src/objects.cc:12570: DCHECK(parameter_map->get(1)->IsDictionary());
Since this is something that callers must ensure, maybe move the DCHECK to the
beginning of the function (near
"DCHECK(object->HasSloppyArgumentsElements());")?

[Jakob Kummerow, 2015-06-18 11:49:17]

Patch set 7 still LGTM.

https://codereview.chromium.org/1177043012/diff/100001/src/lookup.cc
File src/lookup.cc (right):

https://codereview.chromium.org/1177043012/diff/100001/src/lookup.cc#newcode185
src/lookup.cc:185: JSObject::SetSloppyArgumentsElement(holder, index(), value,
attributes);
Arguably this should be called SetDictionaryArgumentsElement now... but IIUC
you're planning further refactorings anyway, so that can wait.

[Toon Verwaest, 2015-06-18 11:52:29]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2015-06-18 11:52:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1177043012/#ps110004
(title: "Rename")

[commit-bot: I haz the power, 2015-06-18 11:52:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1177043012/110004

[commit-bot: I haz the power, 2015-06-18 12:21:02]

Committed patchset #8 (id:110004)

[commit-bot: I haz the power, 2015-06-18 12:21:16]

Patchset 8 (id:??) landed as
https://crrev.com/6a3ba3cc2ce4bec497ea59b925ab4b2280b0f048
Cr-Commit-Position: refs/heads/master@{#29111}