Issue 1177043008: Make it possible to test that the stock app doesn't crash on startup and paints the basic scaffold …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1177043008: Make it possible to test that the stock app doesn't crash on startup and paints the basic scaffold … (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Make it possible to test that the stock app doesn't crash on startup and paints the basic scaffold more or less correctly. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/210ef11a4f59b8e282fa6017bef16e435a230d95

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+220 lines, -127 lines)			Patch
M	sky/examples/stocks2/lib/stock_app.dart	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	sky/sdk/lib/framework/app.dart	View		2 chunks	+10 lines, -5 lines	0 comments	Download
M	sky/sdk/lib/framework/widgets/ui_node.dart	View		4 chunks	+8 lines, -8 lines	0 comments	Download
A	sky/tests/framework/stocks.dart	View		1 chunk	+24 lines, -0 lines	0 comments	Download
A	sky/tests/framework/stocks-expected.txt	View	1	1 chunk	+59 lines, -0 lines	0 comments	Download
M	sky/tests/raw/box_layout.dart	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	sky/tests/raw/box_layout-expected.txt	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	sky/tests/raw/padding_deflate.dart	View		2 chunks	+6 lines, -8 lines	0 comments	Download
M	sky/tests/raw/padding_deflate-expected.txt	View	1	1 chunk	+9 lines, -1 line	0 comments	Download
M	sky/tests/raw/render_box.dart	View		2 chunks	+6 lines, -10 lines	0 comments	Download
M	sky/tests/raw/render_box-expected.txt	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	sky/tests/raw/render_flex.dart	View		3 chunks	+7 lines, -6 lines	0 comments	Download
M	sky/tests/raw/render_flex-expected.txt	View	1	1 chunk	+20 lines, -20 lines	0 comments	Download
M	sky/tests/resources/display_list.dart	View	1	5 chunks	+52 lines, -48 lines	0 comments	Download
M	sky/tools/webkitpy/layout_tests/port/base.py	View		1 chunk	+1 line, -5 lines	0 comments	Download

Total messages: 3 (1 generated)

Hixie

5 years, 6 months ago (2015-06-11 22:36:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
210ef11a4f59b8e282fa6017bef16e435a230d95 (presubmit successful).