Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1177033006: [turbofan] Remove context canonicalization hack from generic lowering. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove context canonicalization hack from generic lowering. This hack doesn't help currently, since it only applies to asm.js where we do function context specialization and there we already have a canonicalized context (and the CodeGenerator materializes that from the frame). R=mstarzinger@chromium.org Committed: https://crrev.com/d06591a2a3bc9643aa5785e1f8c01bd820b7c36a Cr-Commit-Position: refs/heads/master@{#29025}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M src/compiler/js-generic-lowering.cc View 1 chunk +3 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-15 11:59:20 UTC) #1
Benedikt Meurer
Hey Michi, Removing another (now) useless hack. Please take a look. Thanks, Benedikt
5 years, 6 months ago (2015-06-15 11:59:47 UTC) #2
Michael Starzinger
LGTM. Thanks!
5 years, 6 months ago (2015-06-15 12:03:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177033006/1
5 years, 6 months ago (2015-06-15 12:03:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-15 12:21:31 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 12:21:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d06591a2a3bc9643aa5785e1f8c01bd820b7c36a
Cr-Commit-Position: refs/heads/master@{#29025}

Powered by Google App Engine
This is Rietveld 408576698