Source/web/WebViewImpl.cpp - Issue 117703004: Free temporary GPU and memory resources held by inactive or hidden 2D canvases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.cpp

Issue 117703004: Free temporary GPU and memory resources held by inactive or hidden 2D canvases (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: improved test Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/platform/graphics/Canvas2DLayerManager.cpp ('K') | « Source/platform/graphics/ImageBufferSurface.h ('k') | Source/web/tests/Canvas2DLayerManagerTest.cpp » ('j') | Source/web/tests/Canvas2DLayerManagerTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/web/WebViewImpl.cpp

diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp

index ad8cbc499280ccbccd2a7900dbd4895cada18bde..abee3d25bcf090c3eb0022e8c5caf1ee5e989b39 100644

--- a/Source/web/WebViewImpl.cpp

+++ b/Source/web/WebViewImpl.cpp

@@ -3926,8 +3926,8 @@ void WebViewImpl::setVisibilityState(WebPageVisibilityState visibilityState,

ASSERT(visibilityState == WebPageVisibilityStateVisible || visibilityState == WebPageVisibilityStateHidden || visibilityState == WebPageVisibilityStatePrerender);

m_page->setVisibilityState(static_cast<PageVisibilityState>(static_cast<int>(visibilityState)), isInitialState);

+ bool visible = visibilityState == WebPageVisibilityStateVisible;

Stephen White 2014/01/24 18:52:35 Don't see the need for this change; maybe a remnan

if (m_layerTreeView) {

- bool visible = visibilityState == WebPageVisibilityStateVisible;

m_layerTreeView->setVisible(visible);

}