Issue 1176993006: Oilpan: fix build after r196924.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1176993006: Oilpan: fix build after r196924. (Closed)

Created:
4 years, 10 months ago by sof

Modified:
4 years, 10 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, blink-reviews-style_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Oilpan: fix build after r196924. Return type mismatch uncovered by that CL, not the cause. TBR=oilpan-reviews BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196931

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/core/editing/StyledMarkupAccumulator.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (1 generated)

sof

please take a look. It seems to me that compilers ought to have complained before..

4 years, 10 months ago (2015-06-11 09:17:03 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1176993006/1

4 years, 10 months ago (2015-06-11 09:18:03 UTC) #3

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=196931

4 years, 10 months ago (2015-06-11 09:21:27 UTC) #4

Message was sent while issue was closed.

LGTM