content/test/test_render_view_host.cc - Issue 117693002: Make RenderFrameHostManager swap RenderFrameHosts, not RenderViewHosts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/test_render_view_host.cc

Issue 117693002: Make RenderFrameHostManager swap RenderFrameHosts, not RenderViewHosts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/web_contents/web_contents_impl_unittest.cc ('K') | « content/test/test_render_view_host.h ('k') | content/test/test_render_view_host_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/test/test_render_view_host.cc

diff --git a/content/test/test_render_view_host.cc b/content/test/test_render_view_host.cc

index 5c13673b9f52bd53000d6afed75e0b750bafa45d..0754316f419f61ec70d8addb9a69c848c8c0425e 100644

--- a/content/test/test_render_view_host.cc

+++ b/content/test/test_render_view_host.cc

@@ -235,14 +235,12 @@ gfx::NativeViewId TestRenderWidgetHostView::GetParentForWindowlessPlugin()

TestRenderViewHost::TestRenderViewHost(

SiteInstance* instance,

RenderViewHostDelegate* delegate,

- RenderFrameHostDelegate* frame_delegate,

RenderWidgetHostDelegate* widget_delegate,

int routing_id,

int main_frame_routing_id,

bool swapped_out)

: RenderViewHostImpl(instance,

delegate,

- frame_delegate,

widget_delegate,

routing_id,

main_frame_routing_id,

@@ -253,7 +251,8 @@ TestRenderViewHost::TestRenderViewHost(

simulate_fetch_via_proxy_(false),

simulate_history_list_was_cleared_(false),

contents_mime_type_("text/html"),

- opener_route_id_(MSG_ROUTING_NONE) {

+ opener_route_id_(MSG_ROUTING_NONE),

+ main_render_frame_host_(NULL) {

// TestRenderWidgetHostView installs itself into this->view_ in its

// constructor, and deletes itself when TestRenderWidgetHostView::Destroy() is

// called.