Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 117693002: Make RenderFrameHostManager swap RenderFrameHosts, not RenderViewHosts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 69
70 // IPC Message handlers. 70 // IPC Message handlers.
71 void OnDetach(int64 parent_frame_id, int64 frame_id); 71 void OnDetach(int64 parent_frame_id, int64 frame_id);
72 void OnDidStartProvisionalLoadForFrame(int64 frame_id, 72 void OnDidStartProvisionalLoadForFrame(int64 frame_id,
73 int64 parent_frame_id, 73 int64 parent_frame_id,
74 bool main_frame, 74 bool main_frame,
75 const GURL& url); 75 const GURL& url);
76 76
77 bool is_swapped_out() { return is_swapped_out_; } 77 bool is_swapped_out() { return is_swapped_out_; }
78 78
79 // TODO(nasko): This should be removed and replaced by RenderProcessHost. 79 // For now, RenderFrameHosts indirectly keep RenderViewHosts alive via a
80 RenderViewHostImpl* render_view_host_; // Not owned. 80 // refcount that calls Shutdown when it reaches zero. This allows each
81 // RenderFrameHostManager to just care about RenderFrameHosts, while ensuring
82 // we have a RenderViewHost for each RenderFrameHost.
83 // TODO(creis): RenderViewHost will eventually go away and be replaced with
84 // some form of page context.
85 RenderViewHostImpl* render_view_host_;
81 86
82 RenderFrameHostDelegate* delegate_; 87 RenderFrameHostDelegate* delegate_;
83 88
84 // Reference to the whole frame tree that this RenderFrameHost belongs too. 89 // Reference to the whole frame tree that this RenderFrameHost belongs too.
85 // Allows this RenderFrameHost to add and remove nodes in response to 90 // Allows this RenderFrameHost to add and remove nodes in response to
86 // messages from the renderer requesting DOM manipulation. 91 // messages from the renderer requesting DOM manipulation.
87 FrameTree* frame_tree_; 92 FrameTree* frame_tree_;
88 93
89 // The FrameTreeNode which this RenderFrameHostImpl is hosted in. 94 // The FrameTreeNode which this RenderFrameHostImpl is hosted in.
90 FrameTreeNode* frame_tree_node_; 95 FrameTreeNode* frame_tree_node_;
91 96
92 int routing_id_; 97 int routing_id_;
93 bool is_swapped_out_; 98 bool is_swapped_out_;
94 99
95 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl); 100 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl);
96 }; 101 };
97 102
98 } // namespace content 103 } // namespace content
99 104
100 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 105 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698